Closed
Conversation
LegNeato
force-pushed
the
update-2024.06.20
branch
from
2d0121c to
9dccbd0
Compare
Collaborator
Author
|
This is obsoleted by #170 |
Firestar99
added a commit
that referenced
this pull request
Apr 8, 2026
* show-targets comments * TARGET_SPECS has them all at comp time * Update methodology of retrieving targets. use the `cache_dir`, but fallback on the legacy const as it's known to be there, currently the cache_dir's presence is not guaranteed. * filter earlier on to do less hashing. * check dir exists earlier on. * use same error conventions as already in codebase (anyhow) * docs, cleanups * chore: silence clippy * create `mod target_specs` and move all related code there * refactor `update_spec_files` to allow querying `target_specs` dir without updating * make `show targets` use new `target_specs` path querying * fix clippy * update docs on target specs --------- Co-authored-by: Firestar99 <firestar99@sydow.cloud>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should not be merged as the
allocachanges are not correct. I'm putting it up just to save future effort of forward porting.