perf: improve mixer and sample rate conversion #825
Merged
+50
−57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Use VecDeque for output buffering and avoid O(n) remove(0) operations. * Replace Mutex+Atomic pending list with a channel and consume via try_recv. * Drain/retain_mut sources in-place to reduce allocations and copies.
Replace the Vec used for next_sounds with VecDeque to avoid O(n) shifts when removing from the front.
Member
Author
|
1.7% faster on my Raspberry Pi 4 where other math operations dominate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR speeds up
cargo benchby approximately 7.5% on my MacBook Air M3.I had expected that
--features crossbeam-channelwould have been even faster because its operations are lock-free, wherestd::sync::mpscare not. However, the speedup is reduced slightly to 7.4%, probably because there isn't any contention to speak of.Improvements:
VecwithVecDequefor queue and output buffering and avoid O(n)remove(0)operationsMutex+Atomicpending list with a channel and consume viatry_recvretain_mutsources in-place to reduce allocations and copies