Conversation
Uses the non-`pub` `sealed::Sealed` trait introduced in #1227 to explicitly mark that `MontyForm` is not intended to be impl'd by downstream crates. Unlike #1227 this isn't technically a breaking change, because it relies on one of the sealed `Unsigned`/`Integer` types also impl'ing `UnsignedWithMontyForm` which is a bound on the associated `MontyForm::Integer` type.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1237 +/- ##
=======================================
Coverage 90.70% 90.70%
=======================================
Files 185 185
Lines 21415 21415
=======================================
Hits 19424 19424
Misses 1991 1991 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
tarcieri
added a commit
that referenced
this pull request
Mar 25, 2026
## Added - `#[inline]` attributes for shift and wrapping arithmetic ops (#1229) - `MontyForm::{is_zero, is_one}` methods (#1230) - `Gcd` supertrait bound to `Unsigned`/`Signed` traits (#1231) ## Changed - Define `Uint` division traits generically (#1232) - Use generic implementation of bit operations for `Wrapping` (#1235) - Explicitly seal `MontyForm` (#1237)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the non-
pubsealed::Sealedtrait introduced in #1227 to explicitly mark thatMontyFormis not intended to be impl'd by downstream crates.Unlike #1227 this isn't technically a breaking change, because it relies on one of the sealed
Unsigned/Integertypes also impl'ingUnsignedWithMontyFormwhich is a bound on the associatedMontyForm::Integertype.