Skip to content

ml-dsa: missing derives on SigningKey#1281

Merged
tarcieri merged 1 commit intoRustCrypto:masterfrom
baloo:baloo/push-vtmlqvokostw
Apr 3, 2026
Merged

ml-dsa: missing derives on SigningKey#1281
tarcieri merged 1 commit intoRustCrypto:masterfrom
baloo:baloo/push-vtmlqvokostw

Conversation

@baloo
Copy link
Copy Markdown
Member

@baloo baloo commented Apr 2, 2026

When ExpandedSigningKey was split from SigningKey in #1261, the derive for Clone and PartialEq got removed.

When ExpandedSigningKey was split from SigningKey in RustCrypto#1261, the derive
for Clone and PartialEq got removed.
@tarcieri
Copy link
Copy Markdown
Member

tarcieri commented Apr 3, 2026

Ugh, PartialEq derive on ExpandedSigningKey is bad. It should be replaced with a handwritten one that compares the secret components in constant time.

Copy link
Copy Markdown
Member

@tarcieri tarcieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That said, I guess this is fine

@tarcieri tarcieri merged commit 73e7128 into RustCrypto:master Apr 3, 2026
9 checks passed
@baloo baloo deleted the baloo/push-vtmlqvokostw branch April 3, 2026 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants