fix: replace panics with errors in ECB response handling#189
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes panic-based handling in the ECB exchange-rate fetch/parsing path and instead propagates failures as Result errors, improving robustness for callers.
Changes:
- Replace
.expect(...)/.unwrap()with?+ contextualmap_err(...)inget_eur_to_usd_exchange_rate. - Replace
assert_eq!currency validations with explicitErr(...)returns when the ECB response schema doesn’t match expectations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| } | ||
| if ecb_response.currency_denom != "EUR" { | ||
| return Err(format!( | ||
| "Unexpected ECB currency_denom: {}, expected EUR", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace panic! with Error in ecb response handling