Add Auto Migration Default#64
Merged
steeevin88 merged 7 commits intomainfrom Apr 26, 2026
Merged
Conversation
steeevin88
requested changes
Apr 18, 2026
Contributor
steeevin88
left a comment
steeevin88
left a comment
There was a problem hiding this comment.
awesome stuff! besides the comments, a few more points:
- can you change the last sentence in your PR description? it should be "closes", not "closed". closed implies that we close the issue before merging this PR. closes implies that we WILL close the issue after merging this PR
- did you test this locally? i know it's a bit weird to test but since you already had data that wasn't up-to-date i'm guessing you ran the script on it and it worked? just want to confirm quickly
steeevin88
requested changes
Apr 18, 2026
Contributor
steeevin88
left a comment
steeevin88
left a comment
There was a problem hiding this comment.
cool, and again was this tested? just wanna make sure
Contributor
|
KhoaNguyen706
force-pushed
the
khoa/auto-migrate
branch
from
e579d61 to
e9d1dd9
Compare
steeevin88
reviewed
Apr 18, 2026
KhoaNguyen706
force-pushed
the
khoa/auto-migrate
branch
from
e9d1dd9 to
4b941e1
Compare
steeevin88
requested changes
Apr 19, 2026
Contributor
|
also remember to update the PR title lol let's capitalize "Add" |
KhoaNguyen706
force-pushed
the
khoa/auto-migrate
branch
from
79d932f to
2e99f5c
Compare
steeevin88
approved these changes
Apr 26, 2026
Contributor
steeevin88
left a comment
steeevin88
left a comment
There was a problem hiding this comment.
i think this looks fine, if it gets used we can debug in the future
- Parse slice defaults via encoding/json (supports [] and non-empty arrays) - Move migrate usage to cmd/README.md (Purpose / Usage) - Remove verbose comments from migrate.go and cmd/migrate/main.go - Document empty Admins + #65 on Event struct Made-with: Cursor
Made-with: Cursor
…comment Made-with: Cursor
steeevin88
force-pushed
the
khoa/auto-migrate
branch
from
2599f5e to
d9aae76
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add auto migration
closes 62