feat(ui): add tag-based node color coding for lineage DAG#5834
Open
CTC97 wants to merge 2 commits into
Open
Conversation
ba58c85 to
6135f75
Compare
Signed-off-by: CTC97 <ctcurnin@gmail.com>
6135f75 to
0ec81a6
Compare
Signed-off-by: CTC97 <ctcurnin@gmail.com>
29fc936 to
ae2b859
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Gives users the ability to specify colors for nodes with a given tag in their
config.yaml, ex:When a model has multiple tags, the first match wins. Projects without ui.node_colors are unaffected — nodes render with default type-based colors.
At least somewhat related to #4363.
Test Plan
Tested locally.
Checklist
make styleand fixed any issuesmake fast-test)git commit -s) per the DCO