Fix model settings not switching during temp launch#117
Open
yuanzidev wants to merge 1 commit intoSaladDay:mainfrom
Open
Fix model settings not switching during temp launch#117yuanzidev wants to merge 1 commit intoSaladDay:mainfrom
yuanzidev wants to merge 1 commit intoSaladDay:mainfrom
Conversation
The `start claude` command only extracted the `env` sub-object from `settings_config` when building the temporary settings file. This meant model overrides (e.g. `ANTHROPIC_DEFAULT_SONNET_MODEL`) and other top-level fields were missing from the temp file, causing stale model names from the global `~/.claude/settings.json` to bleed through when Claude CLI merged `--settings` with its default config. Now `prepare_launch_with` writes the full `settings_config` (cloned and model-normalized via `normalize_claude_models_in_value`), matching the behavior of the `provider switch` path.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
start claudecommand only extracted theenvsub-object fromsettings_configwhen building the temporary settings file. This meant model overrides (e.g.ANTHROPIC_DEFAULT_SONNET_MODEL) and other top-level fields were missing from the temp file, causing stale model names from the global~/.claude/settings.jsonto bleed through when Claude CLI merged--settingswith its default config.Now
prepare_launch_withwrites the fullsettings_config(cloned and model-normalized vianormalize_claude_models_in_value), matching the behavior of theprovider switchpath.