[WASI] Implement sock_recv#449
Merged
Merged
Conversation
Collaborator
|
Please merge commits using |
Contributor
Author
|
I'll squash the three commits into a single commit shortly. |
hyraxbyerax
force-pushed
the
feat/sock_recv
branch
4 times, most recently
from
July 22, 2026 05:31
a1e612b to
06f82cb
Compare
clover2123
reviewed
Jul 23, 2026
Comment on lines
+397
to
+400
| if (iovptr == nullptr || nread == nullptr || roflags == nullptr) { | ||
| result[0] = Value(WasiErrNo::inval); | ||
| return; | ||
| } |
Collaborator
There was a problem hiding this comment.
What if iovsLen==0 here?
I think that it's better to add iovsLen==0 condition to this if statement
Contributor
Author
There was a problem hiding this comment.
Added a condition to check whether iovsLen == 0 in the if statement. Thanks for pointing it out!
| result[0] = Value(uvwasi_sock_recv(WASI::g_uvwasi, fd, iovs, iovsLen, flags, nread, roflags)); | ||
| } | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Remove this empty line (only one empty line is enough)
Contributor
Author
There was a problem hiding this comment.
Removed the extra empty line. Thanks for the suggestion!
hyraxbyerax
force-pushed
the
feat/sock_recv
branch
5 times, most recently
from
July 23, 2026 07:39
2393ccb to
5e55693
Compare
hyraxbyerax
force-pushed
the
feat/sock_recv
branch
from
July 23, 2026 08:46
5e55693 to
840815d
Compare
hyraxbyerax
force-pushed
the
feat/sock_recv
branch
from
July 23, 2026 09:18
840815d to
9e5d3f1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sock_recvfor WASI.Changes
sock_recvimplementation.sock_recv.Testing