-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
(chore): Remove hardcoded $schema, update metadata #7461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
All changes look good. Wait for review from human collaborators. azure-developer-cli
azure-functions-core-tools
hackernews-tui
pkl-cli
spotify-player
yamlfmt
|
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
📝 WalkthroughWalkthroughThe PR updates six manifest JSON files in the Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Suggested reviewers
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 3
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
bucket/azure-developer-cli.jsonbucket/azure-functions-core-tools.jsonbucket/hackernews-tui.jsonbucket/pkl-cli.jsonbucket/spotify-player.jsonbucket/yamlfmt.json
💤 Files with no reviewable changes (2)
- bucket/spotify-player.json
- bucket/yamlfmt.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-08T10:50:50.148Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Main PR: 6706
File: bucket/acr-cli.json:20-21
Timestamp: 2025-09-08T10:50:50.148Z
Learning: For acr-cli Windows releases, the ZIP files contain "acr-cli.exe" which needs to be renamed to "acr.exe" via pre_install step, despite the command being invoked as "acr" in documentation examples.
Applied to files:
bucket/azure-functions-core-tools.json
🔇 Additional comments (4)
bucket/azure-developer-cli.json (1)
14-18: LGTM: Consistent architecture ordering.The arm64 architecture blocks have been moved to follow the 64bit entries in both the
architectureandautoupdatesections. This improves consistency in the manifest structure without changing any functional data.Also applies to: 42-45
bucket/azure-functions-core-tools.json (2)
16-19: LGTM: Added missing arm64 support in autoupdate.The arm64 architecture block has been properly added to both the
architectureandautoupdatesections, completing the platform support. This ensures the manifest will correctly auto-update for all supported architectures.Also applies to: 33-35
22-24: No action needed — checkver format is correct.The object format with the
githubproperty is a valid Scoop manifest convention and will work correctly with the autoupdate mechanism. This format explicitly specifies the GitHub repository and is fully supported according to Scoop's manifest schema.bucket/hackernews-tui.json (1)
3-3: The description in the file already matches the official GitHub repository description exactly: "A Terminal UI to browse Hacker News". No changes needed.
|
/verify |
|
All changes look good. Wait for review from human collaborators. azure-developer-cli
azure-functions-core-tools
hackernews-tui
pkl-cli
spotify-player
yamlfmt
|
z-Fng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
<manifest-name[@version]|chore>: <general summary of the pull request>Summary by CodeRabbit
Bug Fixes
Chores
✏️ Tip: You can customize this high-level summary in your review settings.