Skip to content

Conversation

@BlackWinnerYoshi
Copy link
Contributor

@BlackWinnerYoshi BlackWinnerYoshi commented Dec 27, 2025

  • Use conventional PR title: <manifest-name[@version]|chore>: <general summary of the pull request>
  • I have read the Contributing Guide

Summary by CodeRabbit

  • Bug Fixes

    • Updated product descriptions for several command-line tools to more accurately reflect their functionality
    • Corrected homepage references to point to official documentation pages
  • Chores

    • Removed schema declarations from manifest files
    • Reorganized configuration entries for consistency

✏️ Tip: You can customize this high-level summary in your review settings.

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

azure-developer-cli

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

azure-functions-core-tools

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

hackernews-tui

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

pkl-cli

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

spotify-player

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

yamlfmt

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

@BlackWinnerYoshi
Copy link
Contributor Author

@coderabbitai review

@coderabbitai
Copy link

coderabbitai bot commented Dec 27, 2025

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@coderabbitai
Copy link

coderabbitai bot commented Dec 27, 2025

📝 Walkthrough

Walkthrough

The PR updates six manifest JSON files in the bucket/ directory, primarily removing $schema field references and updating metadata such as descriptions, homepage URLs, and field structures in select files.

Changes

Cohort / File(s) Summary
Schema Removal Only
bucket/hackernews-tui.json, bucket/spotify-player.json, bucket/yamlfmt.json
Removed top-level $schema field from JSON manifests; all other content preserved.
Description Updates
bucket/azure-developer-cli.json, bucket/hackernews-tui.json
Updated description field with expanded or condensed text; azure-developer-cli.json also reordered architecture/autoupdate entries (arm64 moved after 64bit) without changing values.
Metadata & Structural Changes
bucket/azure-functions-core-tools.json
Removed $schema field; updated description and homepage URLs; restructured checkver from string to object with github key; reorganized architecture entries and added arm64 under autoupdate block.
Homepage URL Update
bucket/pkl-cli.json
Removed $schema field; updated homepage URL to include index.html suffix.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

  • z-Fng

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main changes: removing hardcoded $schema fields and updating metadata across multiple manifest files.
Description check ✅ Passed The PR description follows the repository template with both required checklist items completed, confirming conventional title format and reading the contributing guide.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

📜 Review details

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 22d96ef and 1bf0e1f.

📒 Files selected for processing (6)
  • bucket/azure-developer-cli.json
  • bucket/azure-functions-core-tools.json
  • bucket/hackernews-tui.json
  • bucket/pkl-cli.json
  • bucket/spotify-player.json
  • bucket/yamlfmt.json
💤 Files with no reviewable changes (2)
  • bucket/spotify-player.json
  • bucket/yamlfmt.json
🧰 Additional context used
🧠 Learnings (1)
📚 Learning: 2025-09-08T10:50:50.148Z
Learnt from: o-l-a-v
Repo: ScoopInstaller/Main PR: 6706
File: bucket/acr-cli.json:20-21
Timestamp: 2025-09-08T10:50:50.148Z
Learning: For acr-cli Windows releases, the ZIP files contain "acr-cli.exe" which needs to be renamed to "acr.exe" via pre_install step, despite the command being invoked as "acr" in documentation examples.

Applied to files:

  • bucket/azure-functions-core-tools.json
🔇 Additional comments (4)
bucket/azure-developer-cli.json (1)

14-18: LGTM: Consistent architecture ordering.

The arm64 architecture blocks have been moved to follow the 64bit entries in both the architecture and autoupdate sections. This improves consistency in the manifest structure without changing any functional data.

Also applies to: 42-45

bucket/azure-functions-core-tools.json (2)

16-19: LGTM: Added missing arm64 support in autoupdate.

The arm64 architecture block has been properly added to both the architecture and autoupdate sections, completing the platform support. This ensures the manifest will correctly auto-update for all supported architectures.

Also applies to: 33-35


22-24: No action needed — checkver format is correct.

The object format with the github property is a valid Scoop manifest convention and will work correctly with the autoupdate mechanism. This format explicitly specifies the GitHub repository and is fully supported according to Scoop's manifest schema.

bucket/hackernews-tui.json (1)

3-3: The description in the file already matches the official GitHub repository description exactly: "A Terminal UI to browse Hacker News". No changes needed.

@BlackWinnerYoshi
Copy link
Contributor Author

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

azure-developer-cli

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

azure-functions-core-tools

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

hackernews-tui

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

pkl-cli

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate

spotify-player

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

yamlfmt

  • Lint
  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Check the full log for details.

Copy link
Member

@z-Fng z-Fng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@z-Fng z-Fng merged commit c368d7c into ScoopInstaller:master Jan 3, 2026
3 checks passed
@BlackWinnerYoshi BlackWinnerYoshi deleted the remove-schema branch January 4, 2026 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants