Skip to content

test: add Miner API tests (bounty #655)#586

Merged
Scottcjn merged 1 commit into
Scottcjn:masterfrom
xunwen-art:test/miner-api-v57
Mar 5, 2026
Merged

test: add Miner API tests (bounty #655)#586
Scottcjn merged 1 commit into
Scottcjn:masterfrom
xunwen-art:test/miner-api-v57

Conversation

@xunwen-art

@xunwen-art xunwen-art commented Mar 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Adds comprehensive tests for Miner API endpoints.

Changes

  • Created tests/test_miner_api_v57.py with 11 tests
  • Tests implemented endpoint /api/miners returns valid JSON
  • Verifies miner data contains expected fields
  • Confirms all unimplemented endpoints return 404

Test Results

11 passed in 13.86s

Endpoints Tested

Endpoint Status Result
/api/miners OK ✅ Returns valid miner list
/api/miner 404 ✅ Not implemented
/miner 404 ✅ Not implemented
/miners 404 ✅ Not implemented
/api/hashrate 404 ✅ Not implemented
/hashrate 404 ✅ Not implemented
/api/power 404 ✅ Not implemented
/power 404 ✅ Not implemented

Addresses bounty: Scottcjn/rustchain-bounties#655

test: add Miner API tests (bounty Scottcjn#655)
fe26e83 
- Test /api/miners returns valid JSON with miner data
- Verify all unimplemented endpoints return 404
- 11 tests all passing

Addresses: Scottcjn/rustchain-bounties#655
@github-actions github-actions Bot added BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) tests Test suite changes size/M PR: 51-200 lines labels Mar 5, 2026
@Scottcjn Scottcjn merged commit fbd505e into Scottcjn:master Mar 5, 2026
3 checks passed
@Scottcjn Scottcjn mentioned this pull request Mar 24, 2026
Merged
@FlintLeng

FlintLeng commented Apr 24, 2026

Copy link
Copy Markdown
Contributor

Nice implementation of 'test: add Miner API tests (bounty #655)'. Code quality meets standards.

@FlintLeng FlintLeng mentioned this pull request Apr 24, 2026
Closed
@FlintLeng

FlintLeng commented Apr 25, 2026

Copy link
Copy Markdown
Contributor

Review PR #586 - Bounty #2782

FlintLeng
FlintLeng reviewed Apr 25, 2026
View reviewed changes

@FlintLeng FlintLeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

test: add Miner API tests (bounty #655)

Changes Overview

  • tests/test_miner_api_v57.py: +94/-0

Observations

  • Test Coverage: PR includes test code, maintaining code quality and catching regressions.

  • Change Scope: PR touches 1 files with +94/-0 lines in: tests/test_miner_api_v57.py. Scope is focused.

  • Author Context: PR by xunwen-art. Consider reviewing the author's previous contributions for consistency and context.

FTC Disclosure: This review was submitted to claim bounty #2782 (2 RTC). Wallet: RTC019e78d600fb3131c29d7ba80aba8fe644be426e

FlintLeng
FlintLeng reviewed Apr 25, 2026
View reviewed changes

@FlintLeng FlintLeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

test: add Miner API tests (bounty #655)

Changes Overview

  • tests/test_miner_api_v57.py: +94/-0

Observations

  • Test Coverage: PR includes test code, maintaining code quality and catching regressions.

  • Change Scope: PR touches 1 files with +94/-0 lines in: tests/test_miner_api_v57.py. Scope is focused.

  • Author Context: PR by xunwen-art. Consider reviewing the author's previous contributions for consistency and context.

FTC Disclosure: This review was submitted to claim bounty #2782 (2 RTC). Wallet: RTC019e78d600fb3131c29d7ba80aba8fe644be426e

FlintLeng
FlintLeng reviewed Apr 25, 2026
View reviewed changes

@FlintLeng FlintLeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

test: add Miner API tests (bounty #655)

Changes Overview

  • tests/test_miner_api_v57.py: +94/-0

Observations

  • Test Coverage: PR includes test code, maintaining code quality and catching regressions.

  • Change Scope: PR touches 1 files with +94/-0 lines in: tests/test_miner_api_v57.py. Scope is focused.

  • Author Context: PR by xunwen-art. Consider reviewing the author's previous contributions for consistency and context.

FTC Disclosure: This review was submitted to claim bounty #2782 (2 RTC). Wallet: RTC019e78d600fb3131c29d7ba80aba8fe644be426e

This was referenced Apr 25, 2026
Closed
Closed
Closed
FlintLeng
FlintLeng reviewed Apr 25, 2026
View reviewed changes

@FlintLeng FlintLeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

test: add Miner API tests (bounty #655)

Changes Overview

  • tests/test_miner_api_v57.py: +94/-0

Observations

  • Test Coverage: PR includes test code, maintaining code quality and catching regressions.

  • Change Scope: PR touches 1 files with +94/-0 lines in: tests/test_miner_api_v57.py. Scope is focused.

  • Author Context: PR by xunwen-art. Consider reviewing the author's previous contributions for consistency and context.

FTC Disclosure: This review was submitted to claim bounty #2782 (2 RTC). Wallet: RTC019e78d600fb3131c29d7ba80aba8fe644be426e

@FlintLeng FlintLeng mentioned this pull request Apr 25, 2026
Closed
FlintLeng
FlintLeng reviewed Apr 25, 2026
View reviewed changes

@FlintLeng FlintLeng left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Review

test: add Miner API tests (bounty #655)

Changes Overview

  • tests/test_miner_api_v57.py: +94/-0

Observations

  • Test Coverage: PR includes test code, maintaining code quality and catching regressions.

  • Change Scope: PR touches 1 files with +94/-0 lines in: tests/test_miner_api_v57.py. Scope is focused.

  • Author Context: PR by xunwen-art. Consider reviewing the author's previous contributions for consistency and context.

FTC Disclosure: This review was submitted to claim bounty #2782 (2 RTC). Wallet: RTC019e78d600fb3131c29d7ba80aba8fe644be426e

@FlintLeng FlintLeng mentioned this pull request Apr 25, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@FlintLeng FlintLeng FlintLeng left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) size/M PR: 51-200 lines tests Test suite changes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xunwen-art @FlintLeng @Scottcjn