Skip to content

docs: clarify CPU vote reward weighting#6849

Merged
Scottcjn merged 1 commit into
Scottcjn:mainfrom
FakerHideInBush:codex/readme-cpu-vote-6847
Jun 5, 2026
Merged

docs: clarify CPU vote reward weighting#6849
Scottcjn merged 1 commit into
Scottcjn:mainfrom
FakerHideInBush:codex/readme-cpu-vote-6847

Conversation

@FakerHideInBush
Copy link
Copy Markdown
Contributor

Fixes #6847.

Summary

  • Clarifies that "1 CPU = 1 Vote" means one consensus participation slot per unique hardware device.
  • Clarifies that epoch reward shares are still weighted by the antiquity multiplier, matching the reward example below the section.

Validation

  • git diff --check

wallet: RTCe0961d6b54f2fa96db57a373c84d8ad8986153f8

@github-actions github-actions Bot added documentation Improvements or additions to documentation size/XS PR: 1-10 lines labels Jun 4, 2026
Copy link
Copy Markdown
Contributor

@zqleslie zqleslie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed the docs-only clarification in README.md for the "1 CPU = 1 Vote" section.

What changed:

  • Line 350: "Each unique hardware device gets exactly 1 vote per epoch" → "Each unique hardware device gets one consensus participation slot per epoch"
  • Line 351: "Rewards split equally, then multiplied by antiquity" → "Reward shares are then weighted by the device's antiquity multiplier"

Assessment:

  1. The change is purely cosmetic wording clarification — no functional impact on consensus, mining, or payout logic.
  2. The new wording is more precise: "consensus participation slot" better describes the epoch-based voting mechanism than the vague "1 vote", and "weighted by antiquity multiplier" correctly reflects that reward shares are not equal after the multiplier is applied (the original wording could mislead readers into thinking rewards are split equally before the multiplier).
  3. Diff is 2 lines in README.md only — no code, tests, or config touched.
  4. The change aligns with the existing reward example and multiplier table below this section.

No blocking issues. Safe to merge.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Reviewing the changes.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this PR.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! 🎉 Great contribution to the project.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent contribution to RustChain!

@Scottcjn Scottcjn merged commit 43b7596 into Scottcjn:main Jun 5, 2026
12 checks passed
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! The code changes look good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation size/XS PR: 1-10 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

docs: README has conflicting '1 CPU = 1 Vote' explanation vs epoch reward example

4 participants