Skip to content

feat: add wallet history verifier integration#6850

Merged
Scottcjn merged 1 commit into
Scottcjn:mainfrom
FakerHideInBush:codex/wallet-history-integration-13040
Jun 5, 2026
Merged

feat: add wallet history verifier integration#6850
Scottcjn merged 1 commit into
Scottcjn:mainfrom
FakerHideInBush:codex/wallet-history-integration-13040

Conversation

@FakerHideInBush
Copy link
Copy Markdown
Contributor

Submission for Scottcjn/rustchain-bounties#13040.

Tier: T2 (Verify)
Target: rustchain
Language: Python
Endpoints used: /health, /wallet/history
Wallet: RTCe0961d6b54f2fa96db57a373c84d8ad8986153f8
Starred: yes

What changed:

  • Added a read-only wallet history verifier under integrations/FakerHideInBush-wallet-history/.
  • Verifies live node health, wallet-history ok/miner_id echo, transaction hash shape, known statuses, numeric amounts, and pending transfer_in totals.
  • Avoids private keys, wallet connection, signing, transfers, bridge/swap, and cash-out actions.

Validation:

  • python integrations/FakerHideInBush-wallet-history/wallet_history_verifier.py --miner-id RTCe0961d6b54f2fa96db57a373c84d8ad8986153f8 --limit 3
    • result: verified 3 transaction hash(es); pending transfer_in total: 12.5 RTC
  • python -m py_compile integrations/FakerHideInBush-wallet-history/wallet_history_verifier.py
  • git diff --check

@github-actions github-actions Bot added documentation Improvements or additions to documentation BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) wallet Wallet/transfer related size/M PR: 51-200 lines labels Jun 4, 2026
@zqleslie
Copy link
Copy Markdown
Contributor

zqleslie commented Jun 4, 2026

Reviewed the T2 integration PR from FakerHideInBush for bounty #13040.

What's delivered:

  1. New integration folder integrations/FakerHideInBush-wallet-history/ with:
    • INTEGRATION.md — proper header block parsing: tier=T2, target=rustchain, language=python, wallet=RTC address, starred=yes
    • README.md — run instructions, live transcript, verification scope
    • wallet_history_verifier.py — 122-line stdlib-only Python script

Review points:

  1. Correctness: The script queries /health and /wallet/history endpoints, validates tx_hash format (32-char hex), status whitelist, numeric amounts, and sums pending transfer_in. All checks are sound.
  2. Safety: Read-only — no signing, no private keys, no writes. Uses stdlib urllib (no external deps).
  3. T2 requirement met: Goes beyond T1 rendering by verifying wallet history data integrity (tx hash shape, known statuses, amount totals).
  4. Minor nit: ssl._create_unverified_context() is used by default (acceptable for IP-based endpoint, but --strict-tls flag is provided for production use).
  5. SSRF gap: No explicit SSRF mitigation on the --node URL parameter. For a T2 integration this is acceptable given it defaults to the known RustChain node IP and the README warns about TLS.

Verdict: Meets T2 acceptance criteria. Safe to accept for the integration bounty.


Wallet: XKO212dF8324b9b61F294D26A6Dc68e3f81e4BE451D

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! Reviewing the changes.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great work on this PR.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this PR! 🎉 Great contribution to the project.

Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent contribution to RustChain!

@Scottcjn Scottcjn merged commit 5c4ae73 into Scottcjn:main Jun 5, 2026
12 checks passed
Copy link
Copy Markdown
Contributor

@jaxint jaxint left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Thanks for contributing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BCOS-L1 Beacon Certified Open Source tier BCOS-L1 (required for non-doc PRs) BCOS-L2 Beacon Certified Open Source tier BCOS-L2 (required for non-doc PRs) documentation Improvements or additions to documentation size/M PR: 51-200 lines wallet Wallet/transfer related

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants