Skip to content

Upgrade asset API calls to v4.1 and pass browser user agent #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nicomiguelino wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade asset API calls to v4.1 and pass browser user agent #233

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/assets/ts/features/asset/thunks/submit-asset.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ export const submitAsset = createAsyncThunk<
proposal.title,
headers,
bypassVerification,
navigator.userAgent,
)
: await updateWebAsset(
assetState.assetId,
Expand All @@ -56,6 +57,7 @@ export const submitAsset = createAsyncThunk<
proposal.title,
headers,
bypassVerification,
navigator.userAgent,
);

if (result.length === 0) {
Expand Down
2 changes: 1 addition & 1 deletion src/assets/ts/features/asset/thunks/update-proposal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ export const updateProposal = createAsyncThunk<
].join('&');
const result = await callApi(
'GET',
`v4/assets/?${queryParams.toString()}`,
`v4.1/assets/?${queryParams.toString()}`,
null,
user.token,
);
Expand Down
10 changes: 7 additions & 3 deletions src/assets/ts/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,15 +66,17 @@ export function createWebAsset(
title: string,
headers: object | null,
disableVerification: boolean,
userAgent?: string,
): Promise<AssetResponse[]> {
return callApi(
'POST',
`v4/assets/`,
`v4.1/assets/`,
{
source_url: url,
title: title,
headers: headers,
disable_verification: disableVerification,
...(userAgent ? { user_agent: userAgent } : {}),
},
user.token,
).then((response: ApiResponseData[]) => {
Expand All @@ -89,17 +91,19 @@ export function updateWebAsset(
title: string,
headers: object | null,
disableVerification: boolean,
userAgent?: string,
): Promise<AssetResponse[]> {
const params = new URLSearchParams({ id: `eq.${assetId || ''}` });

return callApi(
'PATCH',
`v4/assets/?${params.toString()}`,
`v4.1/assets/?${params.toString()}`,
{
// API expects snake_case, so we transform from camelCase
title: title,
headers: headers,
disable_verification: disableVerification,
...(userAgent ? { user_agent: userAgent } : {}),
},
user.token,
).then((response: ApiResponseData[]) => {
Expand All @@ -115,7 +119,7 @@ export function getWebAsset(

return callApi(
'GET',
`v4/assets/?${params.toString()}`,
`v4.1/assets/?${params.toString()}`,
null,
user.token,
).then((response: ApiResponseData[]) => {
Expand Down