test(memory): stop daemon before direct database reads - #498
Merged
Conversation
|
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
ScriptedAlchemy
force-pushed
the
codex/fix-memory-eval-db-lock
branch
from
August 4, 2026 12:07
e73fe45 to
e7d7699
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Windows shard 1 in release PR #497 failed because
eval_memory_no_pollutionqueried the fixture database while the daemon still owned a write transaction. The first fix made shard 1 pass, then exposed a Windows teardown race in shard 4: a listener inherited by a child could remain briefly connectable after the owned daemon process exited. The harness now observes endpoint closure rather than assuming process exit immediately releases every inherited handle.Evidence
cargo test --test memory_suite memory_eval_test::eval_memory_no_pollution -- --exact --nocapturecargo test --test memory_suite(52 passed)cargo fmt --all -- --checkgit diff --check