Skip to content

test(memory): stop daemon before direct database reads - #498

Merged
ScriptedAlchemy merged 1 commit into
masterfrom
codex/fix-memory-eval-db-lock
Aug 4, 2026
Merged

test(memory): stop daemon before direct database reads#498
ScriptedAlchemy merged 1 commit into
masterfrom
codex/fix-memory-eval-db-lock

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • stop and fully drop the fixture daemon before the memory eval harness opens SQLite directly
  • on Windows, wait until the recorded loopback endpoint is no longer connectable before restarting
  • restart the daemon only after the direct connection has been dropped
  • apply the lifecycle boundary to both scalar assertions and seeded-source snapshots

Root cause

Windows shard 1 in release PR #497 failed because eval_memory_no_pollution queried the fixture database while the daemon still owned a write transaction. The first fix made shard 1 pass, then exposed a Windows teardown race in shard 4: a listener inherited by a child could remain briefly connectable after the owned daemon process exited. The harness now observes endpoint closure rather than assuming process exit immediately releases every inherited handle.

Evidence

@changeset-bot

changeset-bot Bot commented Aug 4, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: e7d7699

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@ScriptedAlchemy
ScriptedAlchemy force-pushed the codex/fix-memory-eval-db-lock branch from e73fe45 to e7d7699 Compare August 4, 2026 12:07
@ScriptedAlchemy
ScriptedAlchemy merged commit 4eaa5fc into master Aug 4, 2026
16 checks passed
@ScriptedAlchemy
ScriptedAlchemy deleted the codex/fix-memory-eval-db-lock branch August 4, 2026 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant