fix(update): reuse lifecycle lease for Hermes refresh - #499
Merged
Conversation
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Production repro
On the GitHub-installed v0.0.70 binary,
tracedecay updatereportedagent install failed for: hermes; subsequent commands repeated every host integration refresh. Direct Hermes install failed withcannot start legacy Hermes store migration: daemon service install is already activewhile the live daemon held the profile lifecycle lease.Verification
cargo check -p tracedecay-migrate --all-featurescargo clippy -p tracedecay --bin tracedecay --all-features -- -D warningscargo fmt --all -- --checkgit diff --checkNo generated or dashboard build artifacts are committed.