fix(devices/onexplayer_apex): target xbox-elite to surface oxp8 paddles#585
Merged
pastaq merged 2 commits intoMay 9, 2026
Merged
Conversation
The Apex's oxp8 capability map (onexplayer_type8.yaml) emits LeftPaddle1 / RightPaddle1 for the back paddles. Those button codes only exist on the xbox-elite target — under xbox-series they're silently dropped, so the back paddles are dead. 50-onexplayer_x1.yaml already targets xbox-elite for the same reason (its oxp5 map also produces paddle codes). The Apex profile is the inconsistent one. One-line target swap; no other behavior changes.
Contributor
|
Thanks, we somehow missed that during review of the PR that added support. The PR summary feels very LLM oriented. If an LLM was used for any part of this effort please disclose that per the contribution guidance. |
pastaq
requested changes
May 8, 2026
| auto_manage: true | ||
|
|
||
| # The target input device(s) to emulate by default | ||
| # The target input device(s) to emulate by default. xbox-elite (matching |
Contributor
There was a problem hiding this comment.
There is no reason to change anything but the target device. A history and explanation of the change are not required for a single word diff.
… AI use The YAML comment introduced in a3a528d was drafted with Claude. Per CONTRIBUTING.md, AI-generated content must be disclosed in the commit message that introduces it — that disclosure was missed on the original commit. Removing the comment here so the diff against main is the one-line target_devices edit (xbox-series → xbox-elite), which is my own reasoning verified on-device. Also disclosing here that the original PR description (the comparison table, structured test plan, etc.) was drafted with Claude. The fix itself, on-hardware testing, and the technical reasoning behind it are my own. Co-developed-by: Claude Opus 4.7
pastaq
approved these changes
May 9, 2026
github-actions Bot
pushed a commit
that referenced
this pull request
May 9, 2026
## [0.77.1](v0.77.0...v0.77.1) (2026-05-09) ### Bug Fixes * **devices/onexplayer_apex:** target xbox-elite to surface oxp8 paddles ([#585](#585)) ([ce610fe](ce610fe))
Contributor
|
🎉 This PR is included in version 0.77.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The OneXPlayer Apex profile targets
xbox-series, but itsoxp8capability map emitsLeftPaddle1/RightPaddle1— codes that only exist onxbox-elite. So underxbox-seriesthey silently drop and the back paddles do nothing.Switching the target to
xbox-elite(which50-onexplayer_x1.yamlalready does for the same reason, since itsoxp5map also emits paddle codes) makes them surface asBTN_TRIGGER_HAPPY5/BTN_TRIGGER_HAPPY6.Tested on a OneXPlayer Apex (Bazzite, hidraw
1a86:fe00). Before: paddles produce nothing on the emulated/dev/input/eventN. After: they fire as expected. No regression on the rest (sticks, face buttons, triggers, bumpers, dpad).AI disclosure
Per CONTRIBUTING.md: the original PR description and an explanatory YAML comment in the first commit were drafted with Claude. The fix itself, the on-hardware testing, and the reasoning are my own. The follow-up commit
7ed00b7removes the LLM-drafted YAML comment so the diff is exactly the target value change, withCo-developed-by: Claude Opus 4.7in that commit's message.