fix(udev) Resolve permission errors when unhiding devices (#582)#586
Open
dripsnek wants to merge 1 commit into
Open
fix(udev) Resolve permission errors when unhiding devices (#582)#586dripsnek wants to merge 1 commit into
dripsnek wants to merge 1 commit into
Conversation
pastaq
reviewed
May 12, 2026
pastaq
requested changes
May 12, 2026
pastaq
approved these changes
May 12, 2026
Contributor
pastaq
left a comment
pastaq
left a comment
There was a problem hiding this comment.
I still need to test this, but the code looks good.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For devices which use FACLs as part of their udev rules e.g. TAG+="uaccess":
When hiding devices their permissions are modified using chmod, setting a ceiling as to what the FACL permissions can be on that node. Where present, these prohibit the 'pre-hidden' permissions from being reapplied by udev when the device is restored. By clearing any FACLs when hiding, this allows them to be reapplied cleanly when udevadm is reloaded. Devices which do not use FACLs should be unaffected by the additional commands.
For everything else:
An additional check is made for the
/dev/inputplumber/sourcesfolder duringunhide_all()to prevent a file not found error from propagating which can in some circumstances preventudevadmfrom firing leading to incomplete device restoration.Resolves #582