Skip to content

a couple places where ArtQRCode creates a short lived Bitmap but neve… #695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Shane32 merged 1 commit into from
Apr 19, 2026
+10 −6
Merged

a couple places where ArtQRCode creates a short lived Bitmap but neve… #695

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions QRCoder/ArtQRCode.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,17 +83,21 @@ public Bitmap GetGraphic(int pixelsPerModule, Color darkColor, Color lightColor,
if (backgroundImage != null)
{
if (backgroundImageStyle == BackgroundImageStyle.Fill)
graphics.DrawImage(Resize(backgroundImage, size), 0, 0);
{
using var resizedBg = Resize(backgroundImage, size);
graphics.DrawImage(resizedBg, 0, 0);
}
else if (backgroundImageStyle == BackgroundImageStyle.DataAreaOnly)
{
var bgOffset = 4 - offset;
graphics.DrawImage(Resize(backgroundImage, size - (2 * bgOffset * pixelsPerModule)), 0 + (bgOffset * pixelsPerModule), (bgOffset * pixelsPerModule));
using var resizedBg = Resize(backgroundImage, size - (2 * bgOffset * pixelsPerModule));
graphics.DrawImage(resizedBg, 0 + (bgOffset * pixelsPerModule), (bgOffset * pixelsPerModule));
}
}


var darkModulePixel = MakeDotPixel(pixelsPerModule, pixelSize, darkBrush);
var lightModulePixel = MakeDotPixel(pixelsPerModule, pixelSize, lightBrush);
using var darkModulePixel = MakeDotPixel(pixelsPerModule, pixelSize, darkBrush);
using var lightModulePixel = MakeDotPixel(pixelsPerModule, pixelSize, lightBrush);

for (var x = 0; x < numModules; x += 1)
{
Expand Down Expand Up @@ -137,7 +141,7 @@ public Bitmap GetGraphic(int pixelsPerModule, Color darkColor, Color lightColor,
private static Bitmap MakeDotPixel(int pixelsPerModule, int pixelSize, SolidBrush brush)
{
// draw a dot
var bitmap = new Bitmap(pixelSize, pixelSize);
using var bitmap = new Bitmap(pixelSize, pixelSize);
using (var graphics = Graphics.FromImage(bitmap))
{
graphics.FillEllipse(brush, new Rectangle(0, 0, pixelSize, pixelSize));
Expand Down Expand Up @@ -212,7 +216,7 @@ private static Bitmap Resize(Bitmap image, int newSize)
var offsetX = (newSize - scaledWidth) / 2;
var offsetY = (newSize - scaledHeight) / 2;

var scaledImage = new Bitmap(image, new Size(scaledWidth, scaledHeight));
using var scaledImage = new Bitmap(image, new Size(scaledWidth, scaledHeight));

var bm = new Bitmap(newSize, newSize);

Expand Down
Loading