Migrate React Native sample to Expo prebuild#297
Draft
kieran-osgood-shopify wants to merge 6 commits into
Draft
Conversation
fed581f to
525dc82
Compare
525dc82 to
05aecba
Compare
Assisted-By: devx/fb34cb30-8090-438b-b735-1d8f8eb128a6
Assisted-By: devx/741457bb-fda8-43d5-b35b-2e08c409a2fe
Assisted-By: devx/2d0344dc-43dd-4535-baf2-409ff9e93de5
05aecba to
80fa209
Compare
Assisted-By: devx/c25009c8-5a1d-4cb8-aee9-2dcf64902080
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Lockfile maintenance doing some work on the git diff here

dev rn prebuildcommand with--localsupportexpo install --checkwhere the Shopify package proxy has the recommended version availableValidation
dev rn prebuild android --localdev rn prebuild ios --localdev rn test androidwithoutUSE_LOCAL_SDKdev rn test jsdev rn lintpnpm exec expo install --checkfromplatforms/react-native/samplepnpm dlx expo-doctorfromplatforms/react-native/samplewas attempted; remaining failures are fromexpo-doctorshelling out tonpm explain, which is blocked by the workspace npm wrapper/minimum dependency age enforcement undershadowenvgit diff --checkNotes
platforms/react-native/sample/iosandplatforms/react-native/sample/androidare ignored and regenerated via Expo prebuild.expo,expo-build-properties, andexpo-fontare pinned to the newest SDK 56 versions currently available through the Shopify package proxy, and are excluded from Expo dependency validation until the proxy catches up to Expo's latest recommendations.dev rn test iosnow runs withoutUSE_LOCAL_SDK; local validation got as far as the CocoaPods fixture xcodebuild invocation, then failed because the current simulator UUID from the environment was unavailable.