Skip to content

[Performance] Memoize isShopify function#7880

Draft
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-is-shopify-9584385506099802746
Draft

[Performance] Memoize isShopify function#7880
gonzaloriestra wants to merge 1 commit into
mainfrom
performance-memoize-is-shopify-9584385506099802746

Conversation

@gonzaloriestra

Copy link
Copy Markdown
Contributor

Why is this change necessary?

The isShopify function performs a disk I/O check (fileExists) to determine if the dev executable is present. This check is often called multiple times during a single CLI command execution.

How does it address the issue?

This PR introduces memoization for the isShopify function. When called with the default process.env, it stores and returns the same Promise for subsequent calls, avoiding redundant file system operations.

How to test your changes?

CI


PR created automatically by Jules for task 9584385506099802746 started by @gonzaloriestra

Memoizes the `isShopify` function in `packages/cli-kit` to avoid redundant disk I/O when checking for the `dev` executable. This optimization is applied when using the default `process.env`. An internal `_resetIsShopify` function is added to support test isolation.

Expected performance impact: Reduces unnecessary file system checks for the `dev` binary during CLI execution, especially in high-frequency paths.
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@github-actions github-actions Bot added the no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users. label Jun 21, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/context/local.d.ts
@@ -33,6 +33,10 @@ export declare function isVerbose(env?: NodeJS.ProcessEnv): boolean;
  * @returns True if the CLI is used in a Shopify environment.
  */
 export declare function isShopify(env?: NodeJS.ProcessEnv): Promise<boolean>;
+/**
+ * Resets the memoized value for the isShopify check.
+ */
+export declare function _resetIsShopify(): void;
 /**
  * This variable is used when running unit tests to indicate that the CLI's business logic
  * is run as a subject of a unit test. We can use this variable to disable output through

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changelog This PR doesn't include a changeset entry. Is an internal only change not relevant to end users.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant