Skip to content

chore(cookbook): regenerate recipes#3541

Open
itsjustriley wants to merge 1 commit intorecipe-test-infinite-scroll-cleanfrom
recipe-fix-all-recipes
Open

chore(cookbook): regenerate recipes#3541
itsjustriley wants to merge 1 commit intorecipe-test-infinite-scroll-cleanfrom
recipe-fix-all-recipes

Conversation

@itsjustriley
Copy link
Contributor

@itsjustriley itsjustriley commented Mar 6, 2026

WHY are these changes introduced?

Cookbook recipes broke due to skeleton template evolution since February 2026. Changes included import formatting standardization, new features (MockShopNotice, nested cart lines), and monorepo updates. Old patches applied with offset warnings which cookbook validation treats as errors.

WHAT is this pull request doing?

Regenerates 11 cookbook recipe patches to be compatible with the current skeleton template.

Recipe Status: 14 of 14 recipes working (100%)

Fixed in this PR (11 recipes):

  1. bundles
  2. combined-listings
  3. custom-cart-method
  4. metaobjects
  5. partytown
  6. subscriptions
  7. third-party-api
  8. b2b
  9. legacy-customer-account-flow
  10. express
  11. multipass

Fixed in parent/grandparent PRs (2 recipes):

  • infinite-scroll (parent PR)
  • markets (grandparent PR)

Already working (1 recipe):

  • gtm

Manual fixes applied:

Most recipes only required patch regeneration. The following recipes needed manual code changes before regeneration due to significant skeleton template changes:

  • metaobjects: Complete rewrite of app/routes/_index.tsx to use metaobject route content queries instead of featured collections

  • b2b: Updated app/routes/products.$handle.tsx to add buyer context parameter to loader functions for B2B contextualized queries

  • legacy-customer-account-flow: Converted 4 account routes from Customer Account API to legacy Storefront API:

    • app/routes/account._index.tsx: Replaced customerAccount.query() with storefront.query() and session-based auth
    • app/routes/account.orders.$id.tsx: Complete loader rewrite for Storefront API customer order queries
    • app/routes/account.orders._index.tsx: Complete loader rewrite for Storefront API customer orders list
    • app/routes/account.profile.tsx: Complete loader/action rewrite for Storefront API customer updates
  • express: Updated config files to remove Oxygen deployment dependencies:

    • vite.config.ts: Removed import {oxygen} from '@shopify/mini-oxygen/vite' (no longer needed for Node.js/Express)
    • tsconfig.json: Removed @shopify/oxygen-workers-types from types array (Express uses standard Node.js types)
  • multipass: Converted 4 account routes from Customer Account API to legacy Storefront API for Multipass authentication:

    • app/routes/account.$.tsx: Replaced customerAccount.handleAuthStatus() with session-based auth check
    • app/routes/account.addresses.tsx: Converted loader from customerAccount to session + storefront
    • app/routes/account.profile.tsx: Complete loader/action rewrite for Storefront API with session management and password updates
    • app/routes/account.tsx: Complete loader rewrite for session-based routing, authentication, and customer queries

HOW to test your changes?

# Validate all recipes
cd cookbook
pnpm run cookbook validate

All 14 recipes should pass validation.

Checklist

  • I've read the Contributing Guidelines
  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've added a changeset if this PR contains user-facing or noteworthy changes (N/A - cookbook maintenance)
  • I've added tests to cover my changes (N/A - validation tests existing recipes)
  • I've added or updated the documentation (N/A - READMEs auto-generated from recipe.yaml)

@shopify
Copy link
Contributor

shopify bot commented Mar 6, 2026

Oxygen deployed a preview of your recipe-fix-all-recipes branch. Details:

Storefront Status Preview link Deployment details Last update (UTC)
Skeleton (skeleton.hydrogen.shop) ✅ Successful (Logs) Preview deployment Inspect deployment March 17, 2026 2:11 PM

Learn more about Hydrogen's GitHub integration.

@itsjustriley itsjustriley changed the base branch from main to recipe-test-infinite-scroll March 6, 2026 14:57
@itsjustriley itsjustriley changed the title chore(cookbook): regenerate recipes for nested cart lines support chore(cookbook): regenerate recipes Mar 6, 2026
@itsjustriley itsjustriley marked this pull request as ready for review March 6, 2026 18:30
@itsjustriley itsjustriley requested a review from a team as a code owner March 6, 2026 18:30
@binks-code-reviewer
Copy link

🤖 Code Review · Skipped — PR has too many files for review (limit: 50)

Base automatically changed from recipe-test-infinite-scroll to recipe-test-setup March 9, 2026 16:00
Copy link
Contributor

@kdaviduik kdaviduik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the recipe regeneration LGTM though it seems like there was a bad rebase because the infinite scroll E2E tests are inside

@itsjustriley itsjustriley force-pushed the recipe-fix-all-recipes branch from f6ec6ec to 3409464 Compare March 10, 2026 20:24
@itsjustriley itsjustriley changed the base branch from recipe-test-setup to recipe-test-infinite-scroll-clean March 10, 2026 20:24
@itsjustriley itsjustriley force-pushed the recipe-test-infinite-scroll-clean branch from 33d0b4f to 2819265 Compare March 11, 2026 16:33
@itsjustriley itsjustriley force-pushed the recipe-fix-all-recipes branch from 3409464 to 8bfd588 Compare March 11, 2026 16:39
@itsjustriley itsjustriley force-pushed the recipe-test-infinite-scroll-clean branch 2 times, most recently from 1cb21e1 to 02d05a3 Compare March 17, 2026 12:59
…updates

Regenerates all recipe patch files to align with the latest skeleton
template state after the rebase of setup-clean and infinite-scroll-clean
branches. The patch file hash suffixes update to reflect the new file paths.

Recipes updated: b2b, bundles, combined-listings, custom-cart-method,
express, infinite-scroll, legacy-customer-account-flow, metaobjects,
multipass, partytown, subscriptions, third-party-api
@itsjustriley itsjustriley force-pushed the recipe-fix-all-recipes branch from 8bfd588 to 3e95d3d Compare March 17, 2026 14:09
@itsjustriley itsjustriley marked this pull request as draft March 17, 2026 14:09
@itsjustriley itsjustriley marked this pull request as ready for review March 17, 2026 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants