Skip to content

Add base64 as runtime dependency#2095

Open
sawirricardo wants to merge 1 commit into
Shopify:mainfrom
sawirricardo:add-base64-dependency
Open

Add base64 as runtime dependency#2095
sawirricardo wants to merge 1 commit into
Shopify:mainfrom
sawirricardo:add-base64-dependency

Conversation

@sawirricardo

Copy link
Copy Markdown

Problem

Ruby 3.3+ no longer includes base64 as a default gem. Loading liquid on Ruby 3.3+ produces a deprecation warning:

liquid-5.4.0/lib/liquid/standardfilters.rb:4: warning: base64 was loaded from the standard library,
but will no longer be part of the default gems since Ruby 3.4.0.
Add base64 to your Gemfile or gemspec.

Solution

Add base64 as an explicit runtime dependency in the gemspec, matching the approach already used for bigdecimal and strscan.

Testing

All 774 existing tests pass on Ruby 3.4.7.

Fixes #1772

Ruby 3.3+ no longer includes base64 as a default gem. This suppresses
the deprecation warning when loading liquid on Ruby 3.3+.

Fixes Shopify#1772
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Ruby 3.3 deprecation warnings: base64, bigdecimal will no longer be part of the default gems

1 participant