Add cop to disallow case structures where all when clauses are proc literals#797
Open
rwstauner wants to merge 2 commits into
Open
Add cop to disallow case structures where all when clauses are proc literals#797rwstauner wants to merge 2 commits into
rwstauner wants to merge 2 commits into
Conversation
…iterals An if/else tree is equivalent without allocating the procs. This also triggers if the only non-proc clauses are literal values.
rwstauner
force-pushed
the
rwstauner/case-when-all-procs
branch
from
5230147 to
f705f00
Compare
This automated commit dumps the contents of the full RuboCop config. [dependabot skip]
Contributor
|
This feels like one of those things where maybe we should be taking a look at solving it at the interpreter level. Is there a reason an |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An if/else tree is equivalent without allocating the procs.
This also triggers if the only non-proc clauses are literal values.