Skip to content

Append actual value in set_cache #393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yashsinghcodes merged 2 commits into from
Jan 10, 2025
Merged

Append actual value in set_cache #393

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
788aa34
[fix]: Minor bugs in check_cache
yashsinghcodes Jan 10, 2025
91e6177
Merge branch 'Shuffle:master' into new
yashsinghcodes Jan 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions shuffle-tools/1.2.0/run.sh
100644 → 100755
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Build testing
NAME=frikky/shuffle:shuffle-tools_1.1.0
NAME=frikky/shuffle:shuffle-tools_1.2.0
docker rmi $NAME --force
docker build . -t frikky/shuffle:shuffle-tools_1.1.0
docker build . -t frikky/shuffle:shuffle-tools_1.2.0

# Run testing
#docker run -e SHUFFLE_SWARM_CONFIG=run -e SHUFFLE_APP_EXPOSED_PORT=33334 frikky/shuffle:shuffle-tools_1.1.0
Expand Down
9 changes: 8 additions & 1 deletion shuffle-tools/1.2.0/src/app.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1981,7 +1981,14 @@ def check_cache_contains(self, key, value, append):
allvalues["value"].append(value)
exception = ""
try:
# FIXME: This is a hack, but it works
if directcall:
new_value = parsedvalue
if new_value == None:
new_value = [value]

data["value"] = json.dumps(new_value)

set_url = "%s/api/v1/orgs/%s/set_cache" % (self.url, org_id)
response = requests.post(set_url, json=data, verify=False)
allvalues = response.json()
Expand All @@ -1991,7 +1998,7 @@ def check_cache_contains(self, key, value, append):
return {
"success": True,
"found": False,
"reason": "Appended as it didn't exist",
"reason": f"Appended as it didn't exist",
"key": key,
"search": value,
"value": parsedvalue,
Expand Down
Loading