Variable output_string initialized earlier#6
Open
ma-ilsi wants to merge 1 commit intoSinaLab:mainfrom
Open
Conversation
The change prevents the raising of `UnboundLocalError` when passing certain strings found in Arabic corpuses such as "ـ" (Unicode point 0640) to the chained function calls: remove_punctuation(arStrip()).
ma-ilsi
changed the title
output_String initialized earlieroutput_string initialized earlier
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Certain characters can find themselves identified as single words in parsed Arabic corpus data, such as "ـ" (Unicode point 0640). If this "word" is then passed to the SinaTools utilities it may be passed to
arStripand subsequently theremove_punctuationfunction. Such an argument will then raiseUnboundLocalErrorinremove_punctuation(since the argument passed totextis''):A simple fix is to just move the initialization of
output_stringright above thetryblock. This seems very sensible, actually since a fail silently approach works well for this function, leaving the returned value as a blank that was only processed byarStrip.