Use correct Skript class in some registry constructors - #8831
Open
APickledWalrus wants to merge 2 commits into
Open
Use correct Skript class in some registry constructors#8831APickledWalrus wants to merge 2 commits into
APickledWalrus wants to merge 2 commits into
Conversation
APickledWalrus
added
the
enhancement
APickledWalrus
requested review from
Burbulinis and
UnderscoreTud
and removed request for
a team
August 12, 2026 17:05
Absolutionism
approved these changes
Aug 12, 2026
skriptlang-automation
Bot
added
the
needs reviews
sovdeeth
approved these changes
Aug 16, 2026
skriptlang-automation
Bot
added
feature-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PropertyRegistry and EventValueRegistry both need Skript instances to be created, but they are depending on the wrong Skript class: ch.njol.skript.Skript (the plugin class).
Solution
Switches these classes to require a
org.skriptlang.skript.Skriptinstance instead. Retains deprecated constructors for compatibility.Testing Completed
n/a (these values aren't actually used yet)
Supporting Information
Completes: none
Related: none
AI assistance: none