BlockData Support - #8836
Open
Absolutionism wants to merge 3 commits into
Open
Conversation
Absolutionism
requested review from
Efnilite and
cheeezburga
and removed request for
a team
August 13, 2026 17:45
AnOwlBe
reviewed
Aug 13, 2026
AnOwlBe
left a comment
AnOwlBe
left a comment
Contributor
There was a problem hiding this comment.
from a quick glance (mostly just my thoughts)
nothing major though
| } | ||
|
|
||
| @Override | ||
| public BlockData getBlockData(ItemType itemType) { |
Contributor
There was a problem hiding this comment.
is this a safe cast 100% of the time? I didn't really look into it too much though
sovdeeth
requested changes
Aug 13, 2026
| CondBlockDataTag::new, | ||
| types + " (has|have) [the] block[ ]data [tag[s]] %strings%", | ||
| types + " (is|are) tagged with [the] block[ ]data [tag[s]] %strings%", | ||
| types + "(is|are) tagged with %strings% block[ ]data", |
Member
There was a problem hiding this comment.
this pattern in specific is confusing to me
would it not be better to say if {b} has "axis" block data? I think you are over-emphasizing "tags" in these patterns
Contributor
Author
There was a problem hiding this comment.
I was just adding more options, as Mug had preferred the "is tagged" and Pickle said both would be fine.
skriptlang-automation
Bot
added
the
needs reviews
Efnilite
requested changes
Aug 17, 2026
| import java.util.Arrays; | ||
|
|
||
| @Name("Has Block Data") | ||
| @Description("Whether the blockdata of a block or block related object has the specified tag.") |
Member
There was a problem hiding this comment.
Suggested change
| @Description("Whether the blockdata of a block or block related object has the specified tag.") | |
| @Description("Whether the blockdata of a block or block-related object has the specified tag.") |
| CondBlockDataTag::new, | ||
| types + " (has|have) [the] block[ ]data [tag[s]] %strings%", | ||
| types + " (is|are) tagged with [the] block[ ]data [tag[s]] %strings%", | ||
| types + "(is|are) tagged with %strings% block[ ]data", |
Member
There was a problem hiding this comment.
Suggested change
| types + "(is|are) tagged with %strings% block[ ]data", | |
| types + " (is|are) tagged with %strings% block[ ]data", |
| - tag "pickles" will always return an integer value, and can be changed to an integer value or string of an integer: "1" | ||
| """) | ||
| @Example(""" | ||
| set blockdata "waterlogged" of {_campfire} to false |
Member
There was a problem hiding this comment.
Suggested change
| set blockdata "waterlogged" of {_campfire} to false | |
| set blockdata "waterlogged" of {_campfire} to false |
|
|
||
| @Override | ||
| public @Nullable Integer parse(String string) { | ||
| return string.matches("\\d+") ? Integer.parseInt(string) : null; |
Member
There was a problem hiding this comment.
shouldn't this also accept negative values?
Comment on lines
+25
to
+27
| /** | ||
| * @author Peter Güttinger | ||
| */ |
Member
There was a problem hiding this comment.
Suggested change
| /** | |
| * @author Peter Güttinger | |
| */ |
skriptlang-automation
Bot
removed
the
needs reviews
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Skript currently does not support retrieving, changing, and resetting blockdata tags of blocks
Solution
ExprBlockDataTags:
ExprBlockDataValues:
ExprBlockData (Updated):
BlockDataHolder:
BlockDataValueType:
Testing Completed
quickTest, manual testing
Supporting Information
N/A
Completes: none
Related: none
AI assistance: none