EvtPlayerGameModeChange Patch - #8839
Open
AnOwlBe wants to merge 3 commits into
Open
Conversation
AnOwlBe
requested review from
Absolutionism and
Burbulinis
and removed request for
a team
August 16, 2026 02:03
Member
|
This should also make it support plural gamemodes (AND lists) if it doesn't already. |
sovdeeth
approved these changes
Aug 16, 2026
skriptlang-automation
Bot
added
the
needs reviews
Absolutionism
approved these changes
Aug 16, 2026
skriptlang-automation
Bot
added
patch-ready
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Fixes a few issues and does some small cleanup
Fixed an issue where the event only triggered when a player changed their gamemode to survival
Fixed an issue where the
-(marking nullable) was missing for the classinfo in the pattern in the event (for some reason this didn't spit errors before?)Fixes an 'issue' where the
checkcalled getSingle and did a manual checkit now uses gamemode.check which additionally allows for e.g.
on gamemode change to survival or creative:which was previously not possiblein the
initchangedint i(meaning matched pattern) tomatchedPatternandliteralstoargsChanges the var name from
registrytoeventValueRegistry(imo needed since 2 registries are present not just one)Solution
Explained above
Testing Completed
Manual testing completed (and actually did deeper testing this time) all appears to work fine
quicktest passed JUnitQuick failed due to the inventorypickupthing so will have to rely on github's junit tests
Supporting Information
Completes: none
Related: closes and resolves #8837
AI assistance: none