Add section to transform effect - #8840
Open
TFSMads wants to merge 10 commits into
Open
Conversation
TFSMads
requested review from
UnderscoreTud and
erenkarakal
and removed request for
a team
August 16, 2026 19:39
sovdeeth
requested changes
Aug 16, 2026
| } | ||
|
|
||
| return true; | ||
| return trigger != null || mappingExpr != null; |
Member
There was a problem hiding this comment.
currently both a mapping expr and trigger are allowed together, I think it should only allow one or the other.
Contributor
Author
There was a problem hiding this comment.
I think allowing both can be useful. The mapping expression can provide the initial transformation, while the trigger can apply additional logic to the result. I don't see a strong reason to restrict users to one or the other.
AnOwlBe
suggested changes
Aug 16, 2026
skriptlang-automation
Bot
added
the
needs reviews
Contributor
|
great work so far! exciting stuff :) |
Absolutionism
requested changes
Aug 17, 2026
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
skriptlang-automation
Bot
removed
the
needs reviews
Absolutionism
requested changes
Aug 23, 2026
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
Co-authored-by: SirSmurfy2 <82696841+Absolutionism@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
This PR adds section support to transform effect.
Solution
My solutions adds section support to the transform effect and allows transformations within section using ExprInput which i have updated to accept changes if InputSource#allowChanges returns true.
Testing Completed
This PR contains a test script that tests transform section and all supported Change Modes for ExprInput.
Supporting Information
No breaking changes
Completes: #8771
Related: none
AI assistance: none