Function modifier rework - #8847
Open
Efnilite wants to merge 11 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Parameter modifiers previously did not have proper support for containing data within a modifier, requiring messy code to make it work. Additionally, modifiers that defined constraints (such as RangedModifier) required internal changes to check values, thereby not allowing any addon from registering a custom modifier.
Signature modifiers, such as a function being local or returning a value, were previously dictated by fields in the Signature class. To allow for easier future expansion, signature modifiers have been migrated to use the same system as parameter modifiers.
Solution
Parameters
Signature
Priority
Parameters.java
Testing Completed
Added ParameterTest and SignatureTest for testing toFormattedString, and existing tests.
Supporting Information
Completes: none
Related: none
AI assistance: none