[DRAFT] [DO NOT REVIEW] Add ty type checker configuration and Makefile target#499
Draft
kmontemayor2-sc wants to merge 1 commit intomainfrom
Draft
[DRAFT] [DO NOT REVIEW] Add ty type checker configuration and Makefile target#499kmontemayor2-sc wants to merge 1 commit intomainfrom
kmontemayor2-sc wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
Trying to setup
tytype checker, which should be much faster than mypy.Sadly, it seems ty is still in development and is unhappy with
torch.distributed, see astral-sh/ty#2244If/when this get's resolved we should strongly look into migrating
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO