Switch Logger to GCP structured JSON logging via stderr#503
Draft
kmontemayor2-sc wants to merge 6 commits intomainfrom
Draft
Switch Logger to GCP structured JSON logging via stderr#503kmontemayor2-sc wants to merge 6 commits intomainfrom
kmontemayor2-sc wants to merge 6 commits intomainfrom
Conversation
Replace google.cloud.logging.Client().setup_logging() with a StreamHandler writing JSON to stderr, which GCP's logging agent automatically parses into structured LogEntry fields. This removes the network dependency at log time, prevents dropped logs on crash, and produces queryable structured logs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Collaborator
Author
|
/unit_test_py |
Collaborator
Author
|
/e2e_test |
Collaborator
Author
|
/integration_test |
Contributor
GiGL Automation@ 18:24:52UTC : 🔄 @ 19:45:50UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:24:54UTC : 🔄 @ 19:53:39UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 18:25:01UTC : 🔄 @ 19:40:33UTC : ✅ Workflow completed successfully. |
Replace google.cloud.logging.Client().setup_logging() with a StreamHandler writing JSON to stderr, which GCP's logging agent automatically parses into structured LogEntry fields. This removes the network dependency at log time, prevents dropped logs on crash, and produces queryable structured logs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…GiGL into gcp-structured-logging
Replace google.cloud.logging.Client().setup_logging() with a StreamHandler writing JSON to stderr, which GCP's logging agent automatically parses into structured LogEntry fields. This removes the network dependency at log time, prevents dropped logs on crash, and produces queryable structured logs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…GiGL into gcp-structured-logging # Conflicts: # gigl/common/formatters/__init__.py # gigl/common/formatters/gcp_json_formatter.py # gigl/common/logger.py # tests/unit/common/formatters/gcp_json_formatter_test.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace google.cloud.logging.Client().setup_logging() with a StreamHandler writing JSON to stderr, which GCP's logging agent automatically parses into structured LogEntry fields. This removes the network dependency at log time, prevents dropped logs on crash, and produces queryable structured logs.
We need this so we get logs on graph store compute machines :/
I've looked and the other logs seem identical to me.
Scope of work done
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO