Auto-detect if homogeneous with labeled edges when fetching node ids#505
Merged
kmontemayor2-sc merged 1 commit intomainfrom Feb 23, 2026
Merged
Conversation
Collaborator
Author
|
/unit_test_py |
Collaborator
Author
|
/integration_test |
Contributor
GiGL Automation@ 23:42:45UTC : 🔄 @ 24:56:23UTC : ✅ Workflow completed successfully. |
Contributor
GiGL Automation@ 23:42:49UTC : 🔄 @ 24:59:35UTC : ✅ Workflow completed successfully. |
mkolodner-sc
approved these changes
Feb 23, 2026
Collaborator
mkolodner-sc
left a comment
mkolodner-sc
left a comment
There was a problem hiding this comment.
Thanks for the work!
kmontemayor2-sc
requested review from
nshah-sc,
xgao4-sc,
yliu2-sc and
zfan3-sc
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope of work done
For homogeneous with label edges users should be able to write
get_node_ids()and not explicitly provide DEFAULT_HOMOGENEOUS_NODE_TYPE. This change enables that.Also updating the tests so that we test this case.
I thought about doing this on the server but I feel like client side is better so the auto-detection logs are client side which should be less surprising.
Where is the documentation for this feature?: N/A
Did you add automated tests or write a test plan?
Updated Changelog.md? NO
Ready for code review?: NO