Skip to content

Refactor/styles separate css#153

Open
SharonStrats wants to merge 28 commits intomainfrom
refactor/styles-separateCSS
Open

Refactor/styles separate css#153
SharonStrats wants to merge 28 commits intomainfrom
refactor/styles-separateCSS

Conversation

@SharonStrats
Copy link
Contributor

Followed contacts-pane and profile pane to move styles into css files. Also copied over the dev globals for the development environment.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors UI styling by moving inline styles into dedicated CSS files and updates the webpack build/dev setup to bundle CSS, aligning this pane with patterns used in other panes (contacts/profile) and adding local-development global styles.

Changes:

  • Introduced shared webpack moduleRules (including CSS + CSS modules handling) and wired it into both prod and dev webpack configs.
  • Replaced multiple inline style assignments with semantic class names and new CSS files across tracker/issue/board UI.
  • Updated development environment defaults (dev global CSS overrides, Node version guidance via .nvmrc/README, package metadata).

Reviewed changes

Copilot reviewed 18 out of 20 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
webpack.module.rules.mjs New shared webpack module rules, including CSS handling.
webpack.dev.config.mjs Uses shared moduleRules instead of local duplication.
webpack.config.mjs Uses shared moduleRules for production builds.
package.json Marks CSS as side-effectful and adds loaders / Node engine constraint.
.nvmrc Updates the Node version used for development.
README.md Adds development setup instructions (Node + start commands).
dev/index.js Imports dev-global CSS and changes default dev tracker URL.
dev/dev-global.css Adds local-dev global styling variables/resets and accessibility-focused defaults.
src/newTracker.js Replaces inline styling with a CSS class and imports the stylesheet.
src/newIssue.js Adds CSS import, replaces innerHTML with DOM construction, and adds close/cancel behavior.
src/issuePane.js Imports CSS and replaces inline styles with classes (board/table/new issue/overlay/login button).
src/issue.js Imports CSS and replaces many inline styles with classes; adjusts overlay structure.
src/board.js Imports CSS and replaces inline styles with classes for board/table/cards.
src/styles/newTracker.css New CSS for tracker creation button spacing.
src/styles/newIssue.css New CSS for new issue form/title input styling.
src/styles/issuePane.css New CSS for issue pane controls and overlay container.
src/styles/issue.css New CSS for issue overlay/panel and related subcomponents.
src/styles/board.css New CSS for board/table/card layout.
src/styles/csvButton.css Added (currently empty).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

SharonStrats and others added 9 commits March 9, 2026 16:00
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dev/index.js Outdated
// const targetURIToShow = "https://timbl.com/timbl/Automation/mother/tracker.n3#mother"

const targetURIToShow = new URL('./big-tracker.ttl#this', window.location.href).href
const targetURIToShow = "https://sstratsianis.solidcommunity.net/TestingTracker/index.ttl#this";
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to check this in the morning bc it's not like that in my code and it says my code is up to date. a bit weird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants