Skip to content

Remove grep-based static tests from test-update-analysis-as-a-service#175

Merged
nils-werner-sonarsource merged 3 commits into
masterfrom
nw/fix-release-workflow-permission
Jun 29, 2026
Merged

Remove grep-based static tests from test-update-analysis-as-a-service#175
nils-werner-sonarsource merged 3 commits into
masterfrom
nw/fix-release-workflow-permission

Conversation

@nils-werner-sonarsource

@nils-werner-sonarsource nils-werner-sonarsource commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Remove the static-tests job from test-update-analysis-as-a-service.yml — it only grepped for string literals in YAML files, which adds friction without covering real behavior (unit tests do that).

The grep for @master was also fragile on v1 where refs are pinned to the release SHA, causing a spurious failure after every release.

🤖 Generated with Claude Code

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Fix static test triggering on v1 branch where @master refs are pinned GHA-356 Fix static test triggering on v1 branch where @master refs are pinned Jun 29, 2026
@hashicorp-vault-sonar-prod

hashicorp-vault-sonar-prod Bot commented Jun 29, 2026

Copy link
Copy Markdown

GHA-356

@nils-werner-sonarsource nils-werner-sonarsource force-pushed the nw/fix-release-workflow-permission branch from 53039ab to 44e4615 Compare June 29, 2026 09:39
@nils-werner-sonarsource nils-werner-sonarsource changed the title GHA-356 Fix static test triggering on v1 branch where @master refs are pinned Remove grep-based static tests from test-update-analysis-as-a-service Jun 29, 2026
@nils-werner-sonarsource nils-werner-sonarsource merged commit 0521803 into master Jun 29, 2026
7 checks passed
@nils-werner-sonarsource nils-werner-sonarsource deleted the nw/fix-release-workflow-permission branch June 29, 2026 11:55
@sonarqubecloud

Copy link
Copy Markdown

@gitar-bot

gitar-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown
Code Review ✅ Approved

Updates the static test logic to accept both @master and pinned SHA references in action.yml files, preventing build failures on v* branches. No issues found.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants