Skip to content

DO NOT MERGE S6541: reduce noise by dividing found issues count by 15 instead of 10#5714

Open
asya-vorobeva wants to merge 1 commit into
masterfrom
dogfood/improve-s6541
Open

DO NOT MERGE S6541: reduce noise by dividing found issues count by 15 instead of 10#5714
asya-vorobeva wants to merge 1 commit into
masterfrom
dogfood/improve-s6541

Conversation

@asya-vorobeva

@asya-vorobeva asya-vorobeva commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Summary by Gitar

  • Bug fixes and logic changes:
    • Updated S6541 logic to divide the found issues count by 15 instead of 10 to reduce noise.
  • Project configuration:
    • Added sonar-java as a required dependency for Kotlin projects in the build configuration.

This will update automatically on new commits.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot deleted the dogfood/improve-s6541 branch June 29, 2026 14:52
@sonarqube-next

Copy link
Copy Markdown

@gitar-bot

gitar-bot Bot commented Jun 29, 2026

Copy link
Copy Markdown
CI failed: Integration test failures occurred in the `JavaRulingTest` suite across multiple platforms, specifically in the `eclipse_jetty_incremental` test case, due to the logic change in issue counting.

Overview

Two separate CI environments reported integration test failures in JavaRulingTest.eclipse_jetty_incremental following the proposed changes to the S6541 issue counting logic. The tests failed because the actual number of reported issues no longer matches the hardcoded expectations in the test suite.

Failures

Integration Test Regression in JavaRulingTest (confidence: high)

  • Type: test
  • Affected jobs: Ruling QA, 84083705716
  • Related to change: yes
  • Root cause: The logic modification for S6541 (changing the divisor from 10 to 15) has altered the number of issues reported during incremental analysis. The test eclipse_jetty_incremental expects a specific count that is now outdated.
  • Suggested fix: Review the eclipse_jetty_incremental test case in org.sonar.java.it.JavaRulingTest. If the new reporting behavior is intentional, update the test's expected output resources to reflect the new counts. If the discrepancy is unintended, verify the arithmetic logic in the S6541 implementation.

Summary

  • Change-related failures: 2 test failures confirmed, directly caused by the modification of the issue counting algorithm.
  • Infrastructure/flaky failures: 0 (minor Develocity connectivity warnings observed but did not block the core test execution).
  • Recommended action: The developer should update the affected integration test expectations to match the new behavior introduced by the pull request.

Tip

Comment Gitar fix CI or enable auto-apply: gitar auto-apply:on

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change:

Auto-apply Compact
gitar auto-apply:on         
gitar display:verbose         

Was this helpful? React with 👍 / 👎 | Gitar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant