Open
Conversation
VanyaGlazunov
force-pushed
the
feat-add-rdf-graph-load
branch
2 times, most recently
from
e470334 to
9b98673
Compare
VanyaGlazunov
force-pushed
the
feat-add-rdf-graph-load
branch
from
9b98673 to
7fbc869
Compare
suvorovrain
reviewed
Mar 22, 2026
| #[derive(Debug, Clone, Default)] | ||
| pub enum LabelExtraction { | ||
| /// Use only the local name: the fragment (`#name`) or last path segment. | ||
| /// For example, `http://example.org/ns/knows` → `"knows"`. |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// For example, `http://example.org/ns/knows` → `"knows"`. | |
| /// For example, `http://example.org/ns/knows` → `knows`. |
I don't think there should be any quotation marks here so as not to confuse it with literals.
| #[default] | ||
| LocalName, | ||
| /// Use the full IRI string as the label. | ||
| /// For example, `http://example.org/ns/knows` → `"http://example.org/ns/knows"`. |
| } | ||
| } | ||
|
|
||
| impl<R: Read> Iterator for NTriples<R> { |
Collaborator
There was a problem hiding this comment.
<...> <http://a.org/knows> <...>
<...> <http://b.org/knows> <...>
We lose info about difference between these two predicates if use LocalName. Is it good?
| } else if let Some(pos) = iri.rfind('/') { | ||
| iri[pos + 1..].to_owned() | ||
| } else { | ||
| iri.to_owned() |
Collaborator
There was a problem hiding this comment.
can we obtain something like <...> <http://a.org/> <...>? In this case predicate will be empty "". Should we handle this case?
Collaborator
|
@VanyaGlazunov Nice. Can you answer on my questions in review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for loading graphs from RDF N-Triples format as a new edge source.
closes #3 I think.