Skip to content

Conversation

@definitelynotagoblin
Copy link
Contributor

@definitelynotagoblin definitelynotagoblin commented Jan 16, 2026

Description

Version bump v4.5.2

Motivation and Context

https://specterops.atlassian.net/browse/BED-7121

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Chore (a change that does not modify the application functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Documentation updates are needed, and have been made accordingly.
  • I have added and/or updated tests to cover my changes.
  • All new and existing tests passed.
  • My changes include a database migration.

Summary by CodeRabbit

  • Chores
    • Updated package version to 4.5.2. No functional or breaking changes included in this release.

✏️ Tip: You can customize this high-level summary in your review settings.

@definitelynotagoblin definitelynotagoblin self-assigned this Jan 16, 2026
@coderabbitai
Copy link

coderabbitai bot commented Jan 16, 2026

Walkthrough

Two C# project files receive a routine version increment from 4.5.1 to 4.5.2. No functional changes, dependencies modifications, or public API alterations are introduced.

Changes

Cohort / File(s) Summary
Version Bump
src/CommonLib/SharpHoundCommonLib.csproj, src/SharpHoundRPC/SharpHoundRPC.csproj
Version updated from 4.5.1 → 4.5.2 in both project files

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • ktstrader
  • MikeX777

Poem

🐰 A little hop, a little skip, the version takes a trip,
From four-point-five-point-one we go to two with care,
Two humble files, so tidy and so neat,
Make this patch release complete! 🌿✨

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main change: a version bump to v4.5.2, which matches the actual changes in both csproj files.
Description check ✅ Passed The description includes most required sections with the Motivation and Context section linking to the relevant ticket (BED-7121). However, the 'How Has This Been Tested?' section is largely empty with only template comments remaining.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.



📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 8e80419 and e9b97ba.

📒 Files selected for processing (2)
  • src/CommonLib/SharpHoundCommonLib.csproj
  • src/SharpHoundRPC/SharpHoundRPC.csproj
🧰 Additional context used
🧠 Learnings (2)
📚 Learning: 2025-10-17T13:43:46.833Z
Learnt from: MikeX777
Repo: SpecterOps/SharpHoundCommon PR: 241
File: src/CommonLib/Processors/LdapPropertyProcessor.cs:168-169
Timestamp: 2025-10-17T13:43:46.833Z
Learning: Properties added to dictionaries returned by methods in SharpHoundCommon (such as those in LdapPropertyProcessor) may be consumed by dependent projects like SharpHound (SH) and SharpHoundEnterprise (SHE), even if they are not used within the SharpHoundCommon repository itself.

Applied to files:

  • src/CommonLib/SharpHoundCommonLib.csproj
📚 Learning: 2025-07-24T21:38:13.462Z
Learnt from: definitelynotagoblin
Repo: SpecterOps/SharpHoundCommon PR: 229
File: .github/workflows/git-dev.yml:35-39
Timestamp: 2025-07-24T21:38:13.462Z
Learning: In the SpecterOps/SharpHoundCommon repository, the team prefers using `sleet push --force` to overwrite git-dev packages rather than creating unique versions with commit SHAs, as they want a single "current state" package for downstream consumers.

Applied to files:

  • src/CommonLib/SharpHoundCommonLib.csproj
  • src/SharpHoundRPC/SharpHoundRPC.csproj
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: build
🔇 Additional comments (2)
src/CommonLib/SharpHoundCommonLib.csproj (1)

12-12: LGTM!

Version bump to 4.5.2 is consistent with the coordinated update across both projects in this PR. The patch increment is appropriate for a non-functional chore change.

src/SharpHoundRPC/SharpHoundRPC.csproj (1)

11-11: LGTM!

Version bump to 4.5.2 aligns with the companion project SharpHoundCommonLib.csproj, maintaining version consistency across the library components.

✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@definitelynotagoblin definitelynotagoblin merged commit 7a01b9d into v4 Jan 16, 2026
4 checks passed
@definitelynotagoblin definitelynotagoblin deleted the anemeth/version-bump-v4.5.2 branch January 16, 2026 18:28
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants