move and fix Vogels #144
Open
move and fix Vogels #144
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplified version of #138
fixes #136
fixes #71
the cfg and col file not needed
So the test files moved to the paeant directory
note: the GENERATE_PLOT True actually helps testing!
See https://github.com/SpiNNakerManchester/TestBase/blob/875af3d6bbe25ebe41742140b93d4b9af4b4272c/spinnaker_testbase/script_checker.py#L57
when it finds matplotlib.pyplot in the script it mocks that out (python hack)
Then checks the mock is actually called.
Does not check how or with what it is called
ToDo later / removed from this pr to make is simpler
an example for synapses_stdp_izhikevich_neuromodulation_vogels_2011_additive.aplx
typing
changing to method style to highlight the script options better