Rebuild with refreshed dependencies - #207
Conversation
TEMPORARY consumer-copy edits: Compiler .069 (both fallbacks) and CoreJvmCompiler .092. Superseded by the `config` pin bump once it publishes. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Force both Jackson lines, atomicfu, the Protobuf runtime, and Caffeine on the build script and at project level: floor artifacts request the pre-refresh versions, tripping `failOnVersionConflict()`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Force the Jackson 2.x family at project level: the Google Cloud SDK brings its own older `com.fasterxml.*` line, which conflicts with the refreshed baseline under `failOnVersionConflict()`. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`TestDatastoresTest.CreateRemoteDatastore` requires the `spine-dev.json` service-account credential, which is copied into test resources only where it exists. The root build script documents its absence as a warning and expects these suites to skip, but the tests had no guard and failed instead. A `@BeforeEach` assumption restores the documented contract: skipped locally, still executed wherever the credential is present. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
`DatastoreWrapperTest.Remote` already assumed a CI environment inside the test body, but `@BeforeEach` loaded the `spine-dev.json` credential first and threw where it is absent. Moving the assumption into the setup restores the intended skip. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
JUnit runs `@AfterEach` even when `@BeforeEach` aborts on an assumption, so the teardown found the wrapper unassigned where the credential is absent. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Build script: - `Jackson.bom` was listed twice in the same `force(...)` call; this branch added the second copy. - `ToolBase.lib` is `@Deprecated` — the `tool-base` artifact is no longer published and the coordinate 404s. Nothing requests it: the dependency report has no `tool-base` entry. `ToolBase.pluginBase` stays. Tests: - `testBulkRead()` repeated the `assumeTrue(runsOnCi())` that its own `@BeforeEach` already applies, so the inner call could never abort anything. The setup comment claimed the body assumed this "first", which is no longer the arrangement; it now says what it does. - `requireCredential()` hand-rolled a classpath lookup for the credential when the class already has `localResource(String)` and `Resource` exposes `exists()`. `build dokkaGenerate` is green with both Datastore test suites executed, and `dokkaGenerate --rerun-tasks` regenerates all 33 tasks cleanly. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🟡 Changes recommended
The remote Datastore test suite can still fail (instead of skipping) when CI=true but the spine-dev.json credential is absent; the assumption should also verify the credential resource exists.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Automated rebuild PR that refreshes pinned dependencies across the project, bumps the published snapshot version, regenerates dependency reports, and applies small mechanical test/build adjustments needed after upstream changes.
Changes:
- Bumped project snapshot version to
2.0.0-SNAPSHOT.231. - Refreshed dependency pins (including Kotlin/JUnit/Kotest/Protobuf/gRPC/Jackson/Guava) and regenerated
docs/dependencies/*reports. - Adjusted remote Datastore test suites to skip when credentials are not available (and updated dependency forcing rules in
build.gradle.kts).
File summaries
| File | Description |
|---|---|
| version.gradle.kts | Bumps versionToPublish snapshot. |
| testlib/src/test/java/io/spine/testing/server/storage/datastore/TestDatastoresTest.java | Skips remote Datastore tests when spine-dev.json credential is absent. |
| datastore/src/test/java/io/spine/server/storage/datastore/DatastoreWrapperTest.java | Moves remote-suite assumption to @BeforeEach and guards teardown when setup aborts. |
| docs/dependencies/pom.xml | Regenerated dependency report POM with updated versions. |
| docs/dependencies/dependencies.md | Regenerated dependency/license report with updated resolved versions. |
| build.gradle.kts | Updates dependency forcing/alignment (adds Jackson v2 BOM + Protobuf/AtomicFu/Caffeine alignment; removes forcing of deprecated ToolBase artifact). |
| buildSrc/src/main/kotlin/io/spine/dependency/test/Kotest.kt | Updates Kotest version pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/test/JUnit.kt | Updates JUnit/JUnit Platform version pins. |
| buildSrc/src/main/kotlin/io/spine/dependency/storage/PostgreSql.kt | Updates PostgreSQL JDBC driver pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/storage/MySql.kt | Updates MySQL connector pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Validation.kt | Updates Spine Validation pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Logging.kt | Updates Spine Logging pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvmCompiler.kt | Updates Core JVM compiler plugin pins. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/CoreJvm.kt | Updates Spine Core JVM pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Compiler.kt | Updates Spine Compiler fallback pins. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/BaseTypes.kt | Updates Spine Base Types pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/local/Base.kt | Updates Spine Base pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/Roaster.kt | Updates Roaster pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/Protobuf.kt | Updates Protobuf pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/Plexus.kt | Updates Plexus Utils pin and adjusts comment. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/Okio.kt | Updates Okio pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/Netty.kt | Updates Netty pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/Kotlin.kt | Updates Kotlin pin and clarifies embedded vs Gradle-embedded Kotlin semantics. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/JacksonV2.kt | Updates Jackson 2.x pin (for transitive alignment). |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/Jackson.kt | Updates Jackson 3.x pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/HttpClient.kt | Updates Google HTTP Client pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/Guava.kt | Updates Guava pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/Grpc.kt | Updates gRPC pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/GoogleApis.kt | Updates Google Auth Library pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/Firebase.kt | Updates Firebase Admin pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/CommonsLogging.kt | Updates Commons Logging pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/CommonsCodec.kt | Updates Commons Codec pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/lib/AppEngine.kt | Removes AppEngine dependency declarations. |
| buildSrc/src/main/kotlin/io/spine/dependency/kotlinx/Serialization.kt | Updates kotlinx.serialization pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/kotlinx/Coroutines.kt | Updates kotlinx.coroutines pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/kotlinx/AtomicFu.kt | Updates atomicfu pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/build/Pmd.kt | Updates PMD pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/build/Ksp.kt | Updates KSP pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/build/JSpecify.kt | Updates JSpecify pin and copyright year. |
| buildSrc/src/main/kotlin/io/spine/dependency/build/ErrorProne.kt | Updates ErrorProne Gradle plugin pin. |
| buildSrc/src/main/kotlin/io/spine/dependency/build/CheckerFramework.kt | Updates Checker Framework pin. |
| buildSrc/build.gradle.kts | Updates buildSrc plugin/tooling versions (license-report, grgit, kotlin, shadow, etc.). |
Review details
- Files reviewed: 41/43 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #207 +/- ##
=========================================
Coverage 91.05% 91.05%
Complexity 475 475
=========================================
Files 62 62
Lines 1677 1677
Branches 92 92
=========================================
Hits 1527 1527
Misses 121 121
Partials 29 29 🚀 New features to boost your workflow:
|
Summary
Automated cascade wave: rebuild against the refreshed dependency baseline.
Part of a cross-repository wave driven from
summit(seesummit/docs/rollout/rebuild.md); this PR opened only after every dependencyversion pinned here was verified present in the public registry.
Commits
./config/pull) — floated sharedtooling and the config-distributed build files (absent when config was
already current).
io.spine.dependency.localconstantsadvanced to the wave's upstream versions (may appear twice after a drift
refresh).
wave's coordinated target.
docs/dependencies/regenerated by the cleanbuild.
mechanical source fixes; review this commit with extra care.
Verification
./gradlew clean build dokkaGenerategreen locally against the wave'sartifacts (mavenLocal until upstream publication, the registry afterwards).
pre-prreviewers ran at the exact HEAD of this PR (sentinel-gated).europe-maven.pkg.dev/spine-event-enginemetadata beforegh pr create.