Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 19, 2025

Description

Addresses review feedback on PR #1619 regarding the hard-coded net8.0 path in the HintPath for dotnet-gcdump.dll.

Verified that the dotnet-gcdump NuGet package (v9.0.652701) only provides binaries under tools/net8.0/any/ - there is no net10.0 folder. The hard-coded path $(Pkgdotnet-gcdump)\tools\net8.0\any\dotnet-gcdump.dll is correct and necessary, as using $(TargetFramework) would fail when building for net10.0.

Related to #1619

Quality checklist

  • Your code complies with our Coding Style.
  • You've updated unit and/or integration tests for your change, where applicable.
  • You've updated documentation for your change, where applicable.
    If your change affects other repositories, such as Documentation, Samples and/or MainSite, add linked PRs here.
  • There's an open issue for the PR that you are making. If you'd like to propose a new feature or change, please open an issue to discuss the change or find an existing issue.
  • You've added required license files and/or file headers (explaining where the code came from with proper attribution), where code is copied from StackOverflow, a blog, or OSS.

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copilot AI changed the title [WIP] Fix issues raised on gcdump publish and references Verify and confirm dotnet-gcdump net8.0 path is correct Nov 19, 2025
Copilot AI requested a review from bart-vmware November 19, 2025 17:09
@bart-vmware bart-vmware deleted the copilot/sub-pr-1619 branch November 19, 2025 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants