Skip to content

Implement IBinaryPersistableSubtitle in Ayato#10541

Merged
niksedk merged 1 commit intoSubtitleEdit:mainfrom
ivandrofly:ayato-binary-persistable-subtitle
Apr 7, 2026
Merged

Implement IBinaryPersistableSubtitle in Ayato#10541
niksedk merged 1 commit intoSubtitleEdit:mainfrom
ivandrofly:ayato-binary-persistable-subtitle

Conversation

@ivandrofly
Copy link
Copy Markdown
Member

@ivandrofly ivandrofly commented Apr 5, 2026 •
edited
Loading

Summary

  • Make Ayato implement IBinaryPersistableSubtitle interface
  • Extract write logic into WriteToStream method, reused by both Save overloads
  • Remove special-case Ayato handling in BatchConverter (now flows through standard binary path)

Test plan

  • Open a subtitle file and save/export as Ayato (.aya) format — verify the output file is valid
  • Run batch convert with Ayato as target format — verify it uses the IBinaryPersistableSubtitle code path and produces correct output
  • Verify existing Ayato .aya files can still be loaded after the refactor

🤖 Generated with Claude Code

@ivandrofly
refactor: implement IBinaryPersistableSubtitle in Ayato and streaml…
e0e3bb5 
…ine save logic

- Added `Save` method for binary persistence.
- Refactored `Save` logic to use a shared `WriteToStream` method.
- Removed obsolete Ayato-specific handling in `BatchConverter`.
@niksedk niksedk merged commit 7ee7d5a into SubtitleEdit:main Apr 7, 2026
1 check passed
@ivandrofly ivandrofly deleted the ayato-binary-persistable-subtitle branch April 7, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ivandrofly @niksedk