Skip to content

Fix toolbar separator visibility not updating when setting changes#10546

Merged
niksedk merged 1 commit intoSubtitleEdit:mainfrom
ivandrofly:fix-toolbar-separator-visibility
Apr 7, 2026
Merged

Fix toolbar separator visibility not updating when setting changes#10546
niksedk merged 1 commit intoSubtitleEdit:mainfrom
ivandrofly:fix-toolbar-separator-visibility

Conversation

@ivandrofly
Copy link
Copy Markdown
Member

@ivandrofly ivandrofly commented Apr 6, 2026

Summary

  • Store toolbar top separator in ToolbarTopSeparator VM property instead of conditionally adding it
  • Always add the separator to the visual tree but control visibility via IsVisible
  • Update separator visibility in the settings-apply method so toggling the setting takes effect immediately without restart

Test plan

  • Open Settings > Appearance, toggle "Show horizontal line above toolbar" on → separator appears above toolbar
  • Toggle it off → separator disappears immediately
  • Restart the app → setting is preserved correctly

Visual demo

SubtitleEdit_gcgnQ2aVzB

🤖 Generated with Claude Code

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@niksedk niksedk merged commit d952670 into SubtitleEdit:main Apr 7, 2026
1 check passed
@ivandrofly ivandrofly deleted the fix-toolbar-separator-visibility branch April 7, 2026 18:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants