Open
Conversation
loic425
reviewed
Feb 13, 2026
| unset($this->container[$offset]); | ||
| } | ||
|
|
||
| public function __isset(string $name): bool |
Member
There was a problem hiding this comment.
As discussed privately, this is not cool, cause it changes the default behaviour of the native php method.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
isset() returns false even if the key exists, but is set to null. To prevent throwing errors when the key is set to null, maybe we should check only if the key exists 🤔 https://www.php.net/manual/en/function.isset.php