fix: backport im string parsing fix to release-v1#169
Open
MilesCranmerBot wants to merge 8 commits into
Open
Conversation
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Member
|
@MilesCranmerBot CI is failing |
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
MilesCranmer
reviewed
Mar 8, 2026
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
Co-authored-by: Miles Cranmer <miles.cranmer@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #168 to
release-v1.Includes the
imparsing fix and a small release-v1 compatibility adjustment for the new parse test.Validation run locally:
parse_expression("0.1im + x")andparse_expression("im + x2")with assertions on type/evaluation (ok)I did not wait for another full
Pkg.test()pass after the final compatibility patch because it is relatively heavy in this environment.