Fix for lua 5.5 compatibility, for-loop variables are read only#810
Open
Fix for lua 5.5 compatibility, for-loop variables are read only#810
Conversation
Contributor
|
Should have checked PRs 🙃. I've made #811, but the tests are failing there. Want to cross review each other? |
Author
Wow, I also missed #807 actually. You made me realize I've missed quite a few occurrences. I prefer my approach using a different variable name inside the loop, it's less confusing to me. Once we agree on the styling, we can import the changes of one PR into the other, fix the tests and close the remaining PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In lua 5.5, for-loop variables are now read-only, this change produces a bunch of errors similar to this one.
This PR attempts to fix this with minimal changes while trying to maintain code styling.