fix: pass client.offset_encoding to make_position_params (#1)#37
Open
ppmzhang2 wants to merge 1 commit intoTabbyML:mainfrom
Open
fix: pass client.offset_encoding to make_position_params (#1)#37ppmzhang2 wants to merge 1 commit intoTabbyML:mainfrom
ppmzhang2 wants to merge 1 commit intoTabbyML:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a warning emitted by Neovim when invoking
vim.lsp.util.make_position_params()without specifying aposition_encoding. Previously, the plugin always fell back to the default encoding, producing the message:To fix it, we pass
client.offset_encodingtomake_position_paramsinM.request_inline_completionto remove the noisy warning and ensure correct position encoding is used.