feat: added kitchens & subkitchens to country and eta & rating to restaurant#11
Open
Ponynjaa wants to merge 3 commits intoTakeawayAPI:mainfrom
Open
feat: added kitchens & subkitchens to country and eta & rating to restaurant#11Ponynjaa wants to merge 3 commits intoTakeawayAPI:mainfrom
Ponynjaa wants to merge 3 commits intoTakeawayAPI:mainfrom
Conversation
Ponynjaa
changed the title
Ponynjaa
changed the title
Author
|
I'm not too sure about the change of the type for kitchen/subkitchen ids though... they are digits but of type string... its like this "123123" instead of 123123.. I haven't analyzed the code deep enough to see where this is coming from but it would be great if that would also be just a regular number, not a string as it clearly always contains only digits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This MR adds kitchens and subkitchens to the country. Currently this information is lost and not returned to the caller even though there's pieces in the code that suggest, that this feature was intended but wasn't finished maybe?
I also changed the appVersion to '9999.9999.9999' as it also seems to work and won't need to be updated in the future in order to work. This should avoid confusion for the caller as an error is thrown when the appVersion is too low.
I also added "eta" & "rating" ("rvd" - the stars of the restaurant) to restaurant as that was also missing in the model for some reason.