fix(solid-router,vue-router): rebuild inherited link locations on route changes by Sheraff · Pull Request #6877 · TanStack/router

Sheraff · 2026-03-10T08:55:33Z

Summary

track hash and the current leaf match when computing Solid link destinations so inherited and relative links update during navigation
do the same in the Vue adapter so params={true}, hash={true}, and relative to links keep href and isActive in sync
cover the change with the existing adapter link reactivity tests by keeping solid and vue behavior aligned with react

…te changes

coderabbitai · 2026-03-10T08:55:56Z

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9fc6a551-26a2-46af-8b0b-e028c4581858

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch opencode/proud-nebula

Tip

Try Coding Plans. Let us write the prompt for your AI agent so you can ship faster (with fewer bugs).
Share your feedback on Discord.

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

nx-cloud · 2026-03-10T08:56:04Z

View your CI Pipeline Execution ↗ for commit 1b44f8c

Command	Status	Duration	Result
`nx affected --targets=test:eslint,test:unit,tes...`	✅ Succeeded	9m 12s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	44s	View ↗

☁️ Nx Cloud last updated this comment at 2026-03-10 13:00:29 UTC

github-actions · 2026-03-10T08:58:31Z

Bundle Size Benchmarks

Commit: d306d58a2116
Measured at: 2026-03-10T12:52:20.838Z
Baseline source: history:d306d58a2116
Dashboard: bundle-size history

Scenario	Current (gzip)	Delta vs baseline	Raw	Brotli	Trend
`react-router.minimal`	88.10 KiB	+1.03 KiB (+1.18%)	277.68 KiB	76.55 KiB	▁▁▁▁▁▁▁▂▂▂▂█
`react-router.full`	91.30 KiB	+1.28 KiB (+1.42%)	288.44 KiB	79.36 KiB	▁▁▁▁▁▁▁▂▂▂▂█
`solid-router.minimal`	35.24 KiB	-1.15 KiB (-3.16%)	106.53 KiB	31.69 KiB	▇▇▇▇▇▇▇████▁
`solid-router.full`	39.65 KiB	-1.05 KiB (-2.57%)	119.81 KiB	35.63 KiB	▇▇▇▇▇▇▇▇███▁
`vue-router.minimal`	53.21 KiB	+994 B (+1.86%)	152.79 KiB	47.79 KiB	▁▁▁▁▁▁▁▂▂▂▂█
`vue-router.full`	58.25 KiB	+1.21 KiB (+2.12%)	168.77 KiB	52.11 KiB	▁▁▁▁▁▁▁▂▂▂▂█
`react-start.minimal`	100.70 KiB	+1.07 KiB (+1.07%)	316.88 KiB	87.15 KiB	▁▁▁▁▁▁▁▂▂▂▂█
`react-start.full`	104.08 KiB	+1.15 KiB (+1.12%)	327.12 KiB	89.97 KiB	▁▁▁▁▁▁▁▂▂▂▂█
`solid-start.minimal`	47.56 KiB	-1.14 KiB (-2.34%)	144.17 KiB	42.07 KiB	▇▇▇▇▇▇▇████▁
`solid-start.full`	53.16 KiB	-1.01 KiB (-1.86%)	160.35 KiB	46.82 KiB	▇▇▇▇▇▇▇▇███▁

Trend sparkline is historical gzip bytes ending with this PR measurement; lower is better.

pkg-pr-new · 2026-03-10T08:59:27Z

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@6877

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@6877

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@6877

@tanstack/nitro-v2-vite-plugin

npm i https://pkg.pr.new/@tanstack/nitro-v2-vite-plugin@6877

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@6877

@tanstack/react-router-devtools

npm i https://pkg.pr.new/@tanstack/react-router-devtools@6877

@tanstack/react-router-ssr-query

npm i https://pkg.pr.new/@tanstack/react-router-ssr-query@6877

@tanstack/react-start

npm i https://pkg.pr.new/@tanstack/react-start@6877

@tanstack/react-start-client

npm i https://pkg.pr.new/@tanstack/react-start-client@6877

@tanstack/react-start-server

npm i https://pkg.pr.new/@tanstack/react-start-server@6877

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@6877

@tanstack/router-core

npm i https://pkg.pr.new/@tanstack/router-core@6877

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@6877

@tanstack/router-devtools-core

npm i https://pkg.pr.new/@tanstack/router-devtools-core@6877

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@6877

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@6877

@tanstack/router-ssr-query-core

npm i https://pkg.pr.new/@tanstack/router-ssr-query-core@6877

@tanstack/router-utils

npm i https://pkg.pr.new/@tanstack/router-utils@6877

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@6877

@tanstack/solid-router

npm i https://pkg.pr.new/@tanstack/solid-router@6877

@tanstack/solid-router-devtools

npm i https://pkg.pr.new/@tanstack/solid-router-devtools@6877

@tanstack/solid-router-ssr-query

npm i https://pkg.pr.new/@tanstack/solid-router-ssr-query@6877

@tanstack/solid-start

npm i https://pkg.pr.new/@tanstack/solid-start@6877

@tanstack/solid-start-client

npm i https://pkg.pr.new/@tanstack/solid-start-client@6877

@tanstack/solid-start-server

npm i https://pkg.pr.new/@tanstack/solid-start-server@6877

@tanstack/start-client-core

npm i https://pkg.pr.new/@tanstack/start-client-core@6877

@tanstack/start-fn-stubs

npm i https://pkg.pr.new/@tanstack/start-fn-stubs@6877

@tanstack/start-plugin-core

npm i https://pkg.pr.new/@tanstack/start-plugin-core@6877

@tanstack/start-server-core

npm i https://pkg.pr.new/@tanstack/start-server-core@6877

@tanstack/start-static-server-functions

npm i https://pkg.pr.new/@tanstack/start-static-server-functions@6877

@tanstack/start-storage-context

npm i https://pkg.pr.new/@tanstack/start-storage-context@6877

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@6877

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@6877

@tanstack/vue-router

npm i https://pkg.pr.new/@tanstack/vue-router@6877

@tanstack/vue-router-devtools

npm i https://pkg.pr.new/@tanstack/vue-router-devtools@6877

@tanstack/vue-router-ssr-query

npm i https://pkg.pr.new/@tanstack/vue-router-ssr-query@6877

@tanstack/vue-start

npm i https://pkg.pr.new/@tanstack/vue-start@6877

@tanstack/vue-start-client

npm i https://pkg.pr.new/@tanstack/vue-start-client@6877

@tanstack/vue-start-server

npm i https://pkg.pr.new/@tanstack/vue-start-server@6877

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@6877

commit: fdc1fdb

codspeed-hq · 2026-03-10T09:14:16Z

Merging this PR will degrade performance by 41.8%

❌ 2 regressed benchmarks
✅ 4 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Performance Changes

	Benchmark	`BASE`	`HEAD`	Efficiency
❌	`client-side navigation loop (solid)`	63.8 ms	109.6 ms	-41.8%
❌	`client-side navigation loop (vue)`	42 ms	49 ms	-14.31%

_{Comparing opencode/proud-nebula (1b44f8c) with refactor-signals (4a35572)}

fix(solid-router,vue-router): rebuild inherited link locations on rou…

e4761a2

…te changes

github-actions bot added package: solid-router package: vue-router labels Mar 10, 2026

slightly better solid link perf

1b44f8c

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(solid-router,vue-router): rebuild inherited link locations on route changes#6877

fix(solid-router,vue-router): rebuild inherited link locations on route changes#6877
Sheraff wants to merge 2 commits intorefactor-signalsfrom
opencode/proud-nebula

Sheraff commented Mar 10, 2026

Uh oh!

coderabbitai bot commented Mar 10, 2026 •

edited

Loading

Review skipped

Uh oh!

nx-cloud bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

github-actions bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

pkg-pr-new bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

codspeed-hq bot commented Mar 10, 2026 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

Sheraff commented Mar 10, 2026

Summary

Uh oh!

coderabbitai bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Uh oh!

nx-cloud bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Bundle Size Benchmarks

Uh oh!

pkg-pr-new bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codspeed-hq bot commented Mar 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merging this PR will degrade performance by 41.8%

Performance Changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

coderabbitai bot commented Mar 10, 2026 •

edited

Loading

nx-cloud bot commented Mar 10, 2026 •

edited

Loading

github-actions bot commented Mar 10, 2026 •

edited

Loading

pkg-pr-new bot commented Mar 10, 2026 •

edited

Loading

codspeed-hq bot commented Mar 10, 2026 •

edited

Loading